All of lore.kernel.org
 help / color / mirror / Atom feed
From: "K. Y. Srinivasan" <kys@microsoft.com>
To: gregkh@suse.de, linux-kernel@vger.kernel.org,
	devel@linuxdriverproject.org, virtualization@lists.osdl.org,
	ohering@suse.com
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>
Subject: [PATCH 1/4] Drivers: hv: Fix a memory leak
Date: Mon, 12 Dec 2011 09:29:16 -0800	[thread overview]
Message-ID: <1323710959-29655-1-git-send-email-kys@microsoft.com> (raw)
In-Reply-To: <1323710931-29616-1-git-send-email-kys@microsoft.com>

There was a memory leak in a failure path in vmbus_process_offer().
Fix it.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
---
 drivers/hv/channel_mgmt.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
index 12b85ff..b91af50 100644
--- a/drivers/hv/channel_mgmt.c
+++ b/drivers/hv/channel_mgmt.c
@@ -287,6 +287,7 @@ static void vmbus_process_offer(struct work_struct *work)
 		spin_lock_irqsave(&vmbus_connection.channel_lock, flags);
 		list_del(&newchannel->listentry);
 		spin_unlock_irqrestore(&vmbus_connection.channel_lock, flags);
+		kfree(newchannel->device_obj);
 
 		free_channel(newchannel);
 	} else {
-- 
1.7.4.1

  reply	other threads:[~2011-12-12 17:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-12 17:28 [PATCH 0000/0004] Drivers: hv: Fixes K. Y. Srinivasan
2011-12-12 17:29 ` K. Y. Srinivasan [this message]
2011-12-12 17:29   ` [PATCH 2/4] Drivers: hv: Make the vmbus driver unloadable K. Y. Srinivasan
2011-12-12 17:29   ` [PATCH 3/4] Drivers: hv: Get rid of an unnecessary check in hv.c K. Y. Srinivasan
2011-12-12 17:29   ` [PATCH 4/4] Drivers: hv: Support building the vmbus driver as part of the kernel K. Y. Srinivasan
2011-12-12 22:27     ` Greg KH
2011-12-12 23:44       ` KY Srinivasan
2011-12-12 23:49         ` Greg KH
2011-12-12 23:54           ` KY Srinivasan
2011-12-12 22:28 ` [PATCH 0000/0004] Drivers: hv: Fixes Greg KH
2011-12-12 23:50   ` KY Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323710959-29655-1-git-send-email-kys@microsoft.com \
    --to=kys@microsoft.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@suse.de \
    --cc=haiyangz@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ohering@suse.com \
    --cc=virtualization@lists.osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.