From: Dan Luedtke <mail@danrl.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: prism: coding style fixes, removed space-indentations
Date: Tue, 13 Dec 2011 19:50:34 +0100 [thread overview]
Message-ID: <1323802234.22324.4.camel@localhost> (raw)
Hello,
On Tue, Dec 13, 2011 at 7:27 PM, Dan Carpenter
<dan.carpenter@oracle.com> wrote:
> Everyone's first patch is rejected, so don't feel bad. :) Btw put
> these kind of comments which you don't want in the permanent git log
> under the --- dashes. git am removes that information.
Thanks for the feedback! I'm glad I managed git send-email without
breaking up something, so no offense taken that the patch got rejected.
> It looks like you've tried to make everything aligned with the right
> hand side of the screen. I think that's the first time I've seen
> someone do that. I don't think it's normal.
Thank god! I am working on a kmodule, and the code looks awful that way.
I think I have to dig deeper into CodingStyle.txt
>> -----------------------------------------------------------------*/
>> +*----------------------------------------------------------------*/
>
> There is a normal kernel comment style described in Chapter 8 of
> Documentation/CodingStyle.
Now I am confused, as I understand multi-line comments should start
every line but the first with a *.
Anyway, one should commit code before bothering about comments, so I
silence myself here.
> Documentation/kernel-doc-nano-HOWTO.txt
Printed.
Again, thanks for the feedback! Will work on that and come back later
when I found something in the kernel to work on or when my module leaves
design-phase.
regards,
Dan
--
Dan Luedtke
http://www.danrl.de
next reply other threads:[~2011-12-13 18:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 18:50 Dan Luedtke [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-12-13 11:35 [PATCH] staging: wlan-ng: prism: coding style fixes, removed space-indentations Dan Luedtke
2011-12-13 18:27 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323802234.22324.4.camel@localhost \
--to=mail@danrl.de \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.