From: Marcel Holtmann <marcel@holtmann.org>
To: johan.hedberg@gmail.com
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/7] Bluetooth: Move mgmt_set_fast_connectable to the right location
Date: Wed, 14 Dec 2011 23:06:01 +0100 [thread overview]
Message-ID: <1323900361.1965.58.camel@aeonflux> (raw)
In-Reply-To: <1323899524-13653-3-git-send-email-johan.hedberg@gmail.com>
Hi Johan,
> Fast connetable is logically after the connectable property so that's
> where it should show up in the code as well (it's also after connectable
> in the settings bitfield).
>
> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
> ---
> include/net/bluetooth/mgmt.h | 7 ++-----
> net/bluetooth/mgmt.c | 12 ++++++------
> 2 files changed, 8 insertions(+), 11 deletions(-)
Acked-by: Marcel Holtmann <marcel@holtmann.org>
However changing the hci_dev_lock in hci_dev_lock_bh would have been
nice as well, but that becomes obsolete anyway when moving to a
workqueue. So not worth bothering.
Regards
Marcel
next prev parent reply other threads:[~2011-12-14 22:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 21:51 [PATCH 0/7] Update mgmt interface to latest specification johan.hedberg
2011-12-14 21:51 ` [PATCH 1/7] Bluetooth: Update mgmt_read_info and related mgmt messages johan.hedberg
2011-12-14 22:04 ` Marcel Holtmann
2011-12-15 9:02 ` Andrei Emeltchenko
2011-12-15 9:31 ` Johan Hedberg
2011-12-14 21:51 ` [PATCH 2/7] Bluetooth: Move mgmt_set_fast_connectable to the right location johan.hedberg
2011-12-14 22:06 ` Marcel Holtmann [this message]
2011-12-16 6:26 ` Hemant Gupta
2011-12-14 21:52 ` [PATCH 3/7] Bluetooth: Remove mgmt_set_service_cache johan.hedberg
2011-12-14 22:08 ` Marcel Holtmann
2011-12-14 21:52 ` [PATCH 4/7] Bluetooth: Move EIR and CoD update functions to a better position johan.hedberg
2011-12-14 22:09 ` Marcel Holtmann
2011-12-14 21:52 ` [PATCH 5/7] Bluetooth: Add timer for automatically disabling the service cache johan.hedberg
2011-12-14 22:16 ` Marcel Holtmann
2011-12-14 22:25 ` Johan Hedberg
2011-12-14 23:12 ` Marcel Holtmann
2011-12-14 21:52 ` [PATCH 6/7] Bluetooth: Update ordering and opcodes of mgmt messages johan.hedberg
2011-12-14 22:16 ` Marcel Holtmann
2011-12-14 21:52 ` [PATCH 7/7] Bluetooth: Use correct struct for user_confirm_neg_reply johan.hedberg
2011-12-14 22:17 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323900361.1965.58.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.