Re: [PATCH] ASoC: OMAP: HDMI: Prevent DSS module from going idle when playing audio

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 904 bytes --]

On Fri, 2011-12-16 at 01:14 -0700, Paul Walmsley wrote:
> > @@ -572,12 +573,16 @@ int hdmi_audio_trigger(struct
> snd_pcm_substream *substream, int cmd,
> >       case SNDRV_PCM_TRIGGER_START:
> >       case SNDRV_PCM_TRIGGER_RESUME:
> >       case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
> > +             omap_hwmod_set_slave_idlemode(ip_data->oh,
> > +                     HWMOD_IDLEMODE_NO);
> 
> omap_hwmod functions should not be called from device driver code.
> Device 
> drivers should be completely independent of architecture and 
> subarchitecture code.  If you need to do something like this, the way
> to 
> do it is to call an omap_device function through a platform_data
> function 
> pointer.  You may need to create omap_device and/or omap_hwmod
> functions 
> to do what you want to do. 

But with DT we can't use func pointers in platform_data either, right?

 Tomi


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]