All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Sverdlin <subaparts@yandex.ru>
To: Axel Lin <axel.lin@gmail.com>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Mika Westerberg <mika.westerberg@iki.fi>,
	Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 1/2] ASoC: Use dai_fmt in edb93xx machine driver
Date: Sun, 18 Dec 2011 09:45:42 +0100	[thread overview]
Message-ID: <1324197943.4625.0.camel@r60e> (raw)
In-Reply-To: <1324107412.27184.1.camel@phoenix>

Hello!

Acked-by: Alexander Sverdlin <subaparts@yandex.ru>

On Sat, 2011-12-17 at 15:36 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
>  sound/soc/ep93xx/edb93xx.c |   14 ++------------
>  1 files changed, 2 insertions(+), 12 deletions(-)
> 
> diff --git a/sound/soc/ep93xx/edb93xx.c b/sound/soc/ep93xx/edb93xx.c
> index 6b90c75..9f6fecd 100644
> --- a/sound/soc/ep93xx/edb93xx.c
> +++ b/sound/soc/ep93xx/edb93xx.c
> @@ -48,18 +48,6 @@ static int edb93xx_hw_params(struct snd_pcm_substream *substream,
>  	else
>  		mclk_rate = rate * 64 * 2;
>  
> -	err = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S |
> -				  SND_SOC_DAIFMT_NB_IF |
> -				  SND_SOC_DAIFMT_CBS_CFS);
> -	if (err)
> -		return err;
> -
> -	err = snd_soc_dai_set_fmt(cpu_dai, SND_SOC_DAIFMT_I2S |
> -				  SND_SOC_DAIFMT_NB_IF |
> -				  SND_SOC_DAIFMT_CBS_CFS);
> -	if (err)
> -		return err;
> -
>  	err = snd_soc_dai_set_sysclk(codec_dai, 0, mclk_rate,
>  				     SND_SOC_CLOCK_IN);
>  	if (err)
> @@ -80,6 +68,8 @@ static struct snd_soc_dai_link edb93xx_dai = {
>  	.cpu_dai_name	= "ep93xx-i2s",
>  	.codec_name	= "spi0.0",
>  	.codec_dai_name	= "cs4271-hifi",
> +	.dai_fmt	= SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_IF |
> +			  SND_SOC_DAIFMT_CBS_CFS,
>  	.ops		= &edb93xx_ops,
>  };
>  

  parent reply	other threads:[~2011-12-18  8:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-17  7:36 [PATCH 1/2] ASoC: Use dai_fmt in edb93xx machine driver Axel Lin
2011-12-17  7:41 ` [PATCH 2/2] ASoC: Use dai_fmt in snappercl15 " Axel Lin
2011-12-19  9:11   ` Mika Westerberg
2011-12-18  8:45 ` Alexander Sverdlin [this message]
2011-12-20  0:52 ` [PATCH 1/2] ASoC: Use dai_fmt in edb93xx " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1324197943.4625.0.camel@r60e \
    --to=subaparts@yandex.ru \
    --cc=alsa-devel@alsa-project.org \
    --cc=axel.lin@gmail.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@ti.com \
    --cc=mika.westerberg@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.