All of lore.kernel.org
 help / color / mirror / Atom feed
From: Axel Lin <axel.lin@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Michael Hennerich <hennerich@blackfin.uclinux.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	device-drivers-devel@blackfin.uclinux.org
Subject: [PATCH RESEND 1/3] mfd: Fix checking bit_mask for adp5520_set_bits
Date: Mon, 19 Dec 2011 19:55:57 +0800	[thread overview]
Message-ID: <1324295757.3350.3.camel@phoenix> (raw)

Current code checks if all the bit_mask bits are all zero is wrong.
We need to write new value if old value is not equal to new value.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
---
Hi Samuel,
I found this serial of patches are not merged yet. 
( although you replied that you applied all 3 patches in the mail )
It was post on https://lkml.org/lkml/2011/10/30/137
So I resend it again.

Thanks,
Axel
 drivers/mfd/adp5520.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/adp5520.c b/drivers/mfd/adp5520.c
index f1d8848..8d816cc 100644
--- a/drivers/mfd/adp5520.c
+++ b/drivers/mfd/adp5520.c
@@ -109,7 +109,7 @@ int adp5520_set_bits(struct device *dev, int reg, uint8_t bit_mask)
 
 	ret = __adp5520_read(chip->client, reg, &reg_val);
 
-	if (!ret && ((reg_val & bit_mask) == 0)) {
+	if (!ret && ((reg_val & bit_mask) != bit_mask)) {
 		reg_val |= bit_mask;
 		ret = __adp5520_write(chip->client, reg, reg_val);
 	}
-- 
1.7.5.4




             reply	other threads:[~2011-12-19 11:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-19 11:55 Axel Lin [this message]
2011-12-19 11:57 ` [PATCH RESEND 2/3] mfd: da903x: Ensure setting bits if new value is different from the old value Axel Lin
2011-12-19 11:59 ` [PATCH RESEND 3/3] mfd: tps6586x: " Axel Lin
2011-12-19 12:25 ` [PATCH RESEND 1/3] mfd: Fix checking bit_mask for adp5520_set_bits Axel Lin
2011-12-19 17:54   ` Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1324295757.3350.3.camel@phoenix \
    --to=axel.lin@gmail.com \
    --cc=device-drivers-devel@blackfin.uclinux.org \
    --cc=hennerich@blackfin.uclinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.