From: Tony Olech <tony.olech@elandigitalsystems.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
Pawel Moll <pawel.moll@arm.com>, Chris Ball <cjb@laptop.org>,
linux-mmc@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 4/15] vub300: fix module parameter.
Date: Mon, 19 Dec 2011 13:08:40 +0000 [thread overview]
Message-ID: <1324300120.4283.6.camel@study-2> (raw)
In-Reply-To: <1324062122.2302.5.camel@study-2>
On Thu, 2011-12-15 at 13:34 +1030, Rusty Russell wrote:
> You didn't mean this to be a bool.
>
> Cc: Tony Olech <tony.olech@elandigitalsystems.com>
> Cc: Chris Ball <cjb@laptop.org>
> Cc: linux-mmc@vger.kernel.org
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> ---
> drivers/mmc/host/vub300.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
> --- a/drivers/mmc/host/vub300.c
> +++ b/drivers/mmc/host/vub300.c
> @@ -259,7 +259,7 @@ static int firmware_rom_wait_states = 0x
> static int firmware_rom_wait_states = 0x1C;
> #endif
>
> -module_param(firmware_rom_wait_states, bool, 0644);
> +module_param(firmware_rom_wait_states, int, 0644);
> MODULE_PARM_DESC(firmware_rom_wait_states,
> "ROM wait states byte=RRRIIEEE (Reserved Internal External)");
>
> --
You are right.
I don't know how that slipped through
Acked-by: Tony Olech <tony.olech@elandigitalsystems.com>
Acked-by: Tony Olech <tony@olech.com>
prev parent reply other threads:[~2011-12-19 13:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 3:04 [PATCH 4/15] vub300: fix module parameter Rusty Russell
2011-12-15 3:04 ` Rusty Russell
2011-12-16 19:02 ` Tony Olech
2011-12-19 2:20 ` Rusty Russell
2011-12-20 0:03 ` Chris Ball
2011-12-19 13:08 ` Tony Olech [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324300120.4283.6.camel@study-2 \
--to=tony.olech@elandigitalsystems.com \
--cc=cjb@laptop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.