From: George Dunlap <george.dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"Keir (Xen.org)" <keir@xen.org>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Eddie Dong <eddie.dong@intel.com>, Hui Lv <hui.lv@intel.com>,
Jiangang Duan <jiangang.duan@intel.com>,
Zhidong Yu <zhidong.yu@intel.com>
Subject: Re: [PATCH v2] xen/credit scheduler; Use delay to control scheduling frequency
Date: Mon, 19 Dec 2011 16:48:48 +0000 [thread overview]
Message-ID: <1324313328.2143.74.camel@elijah> (raw)
In-Reply-To: <4EEF686E0200007800068DCC@nat28.tlf.novell.com>
On Mon, 2011-12-19 at 15:38 +0000, Jan Beulich wrote:
> >>> On 19.12.11 at 16:25, "Lv, Hui" <hui.lv@intel.com> wrote:
> >> Overriding the rate limit by the time slice isn't the right thing either, as
> > that
> >> (the way I "read" it) means there's no rate limiting at all.
> >> What "rate limit" to me means is preventing quickly switching away from a
> >> vCPU recently scheduled without extending its (remaining) time slice, i.e.
> > in any
> >> place a respective evaluation is done the shorter of the two should be used.
> >>
> >> Jan
> >
> > So the basic thing is to avoid "time slice" < "rate limit", happen.
> > I really don't understand why people want a 1ms time slice, but set the
> > rate_limit to 5000(us), that is insubstantial.
>
> So if someone set the (global) rate limit value to 5000us and then,
> days or weeks later, migrates a VM with a 3ms time slice to that
> host, why should this be an admin mistake? To me, the rate limit is a
> performance improvement, while the time slice may be (an indirect
> result of) a to be enforced policy.
Right now the timeslice is effectively global. There's a per-scheduler
variable, but it's only set from the boot-time option. Before 4.2 I'm
going to add some code that will allow that to be changed on a scheduler
granularity; but there was never a plan to make it per-VM.
It would make sense, in theory, to let the VM run for the rest of its
timeslice; but there's not an easy way at the moment to get that
information from an already-running vcpu. The timescales we're talking
about here are so small that it doesn't seem worth the extra
complication to me.
We're really bike-shedding at this point. I don't think
functionality-wise it matters either way, and the code is simpler the
way it is. I think we should just leave it.
-George
next prev parent reply other threads:[~2011-12-19 16:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Acy8a1J98NIQa/LRTpOgi509iCZVqg==>
2011-12-17 3:24 ` [PATCH v2] xen/credit scheduler; Use delay to control scheduling frequency Lv, Hui
2011-12-19 8:24 ` Jan Beulich
2011-12-19 11:32 ` George Dunlap
2011-12-19 12:05 ` Jan Beulich
2011-12-19 13:59 ` George Dunlap
2011-12-19 14:59 ` Jan Beulich
2011-12-19 15:25 ` Lv, Hui
2011-12-19 15:38 ` Jan Beulich
2011-12-19 16:48 ` George Dunlap [this message]
2011-12-19 17:04 ` Jan Beulich
2011-12-19 13:56 ` Lv, Hui
2011-12-19 10:54 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324313328.2143.74.camel@elijah \
--to=george.dunlap@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=eddie.dong@intel.com \
--cc=hui.lv@intel.com \
--cc=jiangang.duan@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=xen-devel@lists.xensource.com \
--cc=zhidong.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.