From: Ben Hutchings <ben@decadent.org.uk>
To: Anil Ravindranath <anil_ravindranath@pmc-sierra.com>,
linux-scsi@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 8/8] pmcraid: Pass pointers to access_ok(), not integers
Date: Wed, 21 Dec 2011 01:37:26 +0000 [thread overview]
Message-ID: <1324431446.2844.155.camel@deadeye> (raw)
In-Reply-To: <1324430940.2844.144.camel@deadeye>
Most architectures define access_ok() as a macro that casts its
argument such that an argument of type unsigned long will be accepted
without complaint. However, the proper type is void *, and passing
unsigned long results in a warning on sparc64.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
drivers/scsi/pmcraid.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index 5163edb..01b29a6 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -3807,7 +3807,8 @@ static long pmcraid_ioctl_passthrough(
}
if (request_size > 0) {
- rc = access_ok(access, arg, request_offset + request_size);
+ rc = access_ok(access, (void *)arg,
+ request_offset + request_size);
if (!rc) {
rc = -EFAULT;
--
1.7.7.3
prev parent reply other threads:[~2011-12-21 1:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 1:29 [PATCH 0/8] Fix virtual and physical address types Ben Hutchings
2011-12-21 1:29 ` Ben Hutchings
2011-12-21 1:32 ` [PATCH 1/8] IB/cxgb4: Fix formatting of physical address Ben Hutchings
2011-12-21 1:32 ` Ben Hutchings
2011-12-21 2:35 ` Joe Perches
2011-12-21 2:35 ` Joe Perches
2011-12-21 2:47 ` Ben Hutchings
2011-12-22 19:52 ` Valdis.Kletnieks-PjAqaU27lzQ
2011-12-22 19:52 ` Valdis.Kletnieks
2011-12-21 14:12 ` Steve Wise
2011-12-21 14:12 ` Steve Wise
2011-12-21 1:32 ` [PATCH 2/8] farsync: Fix confusion about DMA address and buffer offset types Ben Hutchings
2011-12-21 1:42 ` Ben Hutchings
2011-12-21 4:48 ` David Miller
2011-12-21 5:41 ` Ben Hutchings
2011-12-21 4:46 ` David Miller
2011-12-21 5:41 ` Ben Hutchings
2011-12-21 8:33 ` Kevin Curtis
2011-12-21 8:33 ` Kevin Curtis
2011-12-21 1:33 ` [PATCH 3/8] drm: Do not include page offset in argument to virt_to_page() Ben Hutchings
2011-12-21 1:33 ` [PATCH 4/8] drm: Pass pointers " Ben Hutchings
2011-12-21 1:34 ` [PATCH 5/8] [SCSI] tgt: Pass pointers to virt_to_page(), not integers Ben Hutchings
2011-12-21 1:36 ` [PATCH 6/8] uio: " Ben Hutchings
2011-12-21 1:59 ` Hans J. Koch
2011-12-21 1:36 ` [PATCH 7/8] rds: " Ben Hutchings
2011-12-21 1:37 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324431446.2844.155.camel@deadeye \
--to=ben@decadent.org.uk \
--cc=anil_ravindranath@pmc-sierra.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.