From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH] sedf: remove useless tracing printk and harmonize comments style. Date: Wed, 21 Dec 2011 14:42:42 +0100 Message-ID: <1324474962.2581.4.camel@Solace> References: <1324454839.2682.1.camel@Solace> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4936964494995583975==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: George Dunlap Cc: "xen-devel@lists.xensource.com" , Keir Fraser List-Id: xen-devel@lists.xenproject.org --===============4936964494995583975== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-RKi6krBp20+bW/XbN6cQ" --=-RKi6krBp20+bW/XbN6cQ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2011-12-21 at 12:21 +0000, George Dunlap wrote: > RE removing the prinks, and most of the comment changes, ACK. >=20 Ok, that's what counts most. :-) > However, I think the typical comment style is that you should either > do things this way: >=20 > /* A one-line comment, start and end in one line */ >=20 > Or this way: > /* > * A multi-line comment, > * Where the opening and closing each have their own line. > */ >=20 Which is my favorite... > Or, > /* If you have a short comment that can't fit on > * one line, put it on two, but with out any extra lines. */ >=20 > But you seem to be replacing all multi-line comments with this: >=20 > /* The first line having the open-comment at the benning, > * But the close-comment having its own line. > */ >=20 It looks weird to me too, but I'm sure I've seen it in a couple of source files in xen (and it looked weird at that time too! :-P). Moreover, it was like that on many multiline comments in sched_sedf.c, so I just changed the one with an even weirder one to it. > I've never seen that before, and it looks a bit weird. :-) >=20 100% Agree. :-) > I prefer the first two, with judicious use of the third when appropriate. >=20 I can't be more happy to hear that, I'll go for the first, the one with both wings. :-D Thanks, Dario --=20 <> (Raistlin Majere) ------------------------------------------------------------------- Dario Faggioli, http://retis.sssup.it/people/faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) PhD Candidate, ReTiS Lab, Scuola Superiore Sant'Anna, Pisa (Italy) --=-RKi6krBp20+bW/XbN6cQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAk7x4lIACgkQk4XaBE3IOsQQDACeJAkdWopkl0CzWVVT/zXZRCyH NVEAn2+vtPG78PdYgEe4Fws+GPrdhFV0 =O4a4 -----END PGP SIGNATURE----- --=-RKi6krBp20+bW/XbN6cQ-- --===============4936964494995583975== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============4936964494995583975==--