From: Ben Hutchings <bhutchings@solarflare.com>
To: <kgudipat@brocade.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<adapter_linux_open_src_team@brocade.com>, <rmody@brocade.com>
Subject: Re: [PATCH 1/2] bna: Added flash sub-module and ethtool eeprom entry points.
Date: Fri, 23 Dec 2011 09:44:22 +0000 [thread overview]
Message-ID: <1324633462.3860.6.camel@deadeye> (raw)
In-Reply-To: <1324596585-8614-1-git-send-email-kgudipat@brocade.com>
On Thu, 2011-12-22 at 15:29 -0800, kgudipat@brocade.com wrote:
> From: Krishna Gudipati <kgudipat@brocade.com>
>
> Change details:
> - The patch adds flash sub-module to the bna driver.
> - Added ethtool set_eeprom() and get_eeprom() entry points to
> support flash partition read/write operations.
[...]
I'm not going to say this is wrong, but we didn't find the EEPROM
operations suitable for firmware upgrade. I have a couple of questions:
1. How long can a single set_eeprom() operation take?
2. Have you considered implementing the flash_device() operation or an
MTD driver?
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-12-23 9:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 23:29 [PATCH 1/2] bna: Added flash sub-module and ethtool eeprom entry points kgudipat
2011-12-23 9:44 ` Ben Hutchings [this message]
2011-12-23 15:09 ` Krishna Gudipati
2011-12-24 10:08 ` Ben Hutchings
2011-12-26 12:02 ` Jan Ceuleers
2011-12-26 15:10 ` David Miller
2011-12-26 15:46 ` Jan Ceuleers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324633462.3860.6.camel@deadeye \
--to=bhutchings@solarflare.com \
--cc=adapter_linux_open_src_team@brocade.com \
--cc=davem@davemloft.net \
--cc=kgudipat@brocade.com \
--cc=netdev@vger.kernel.org \
--cc=rmody@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.