All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Vincent Pelletier <plr.vincent-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: Bisect: i2c regression in 63daa9589cb88617d9cc8a0b0282564682a975b7
Date: Tue, 03 Jan 2012 08:40:10 +1000	[thread overview]
Message-ID: <1325544010.8507.1.camel@nisroch> (raw)
In-Reply-To: <201201012238.25620.plr.vincent-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Sun, 2012-01-01 at 22:38 +0100, Vincent Pelletier wrote:
> Hi.
Hey,

> 
> Updating nouveau module to a newer git revision, I noticed I lost hwmon.
> 
> I ran a bisect, which identified 63daa9589cb88617d9cc8a0b0282564682a975b7 as 
> being the first bad commit.
> 
> Adding printk traces, I saw that probing i2c bus 3 for sensors always failed 
> with -EIO (no ack from slave). After reading the code, remembering how i2c 
> works and reading sample code on wikipedia, I couldn't identify any 
> algorythmic problem.
> 
> So I gave a try at changing delays. I doubled T_RISEFALL and T_HOLD, and the 
> adt7473 chip could be detected & used again. I haven't tested other 
> combination, nor tried to link those delays with any datasheet.
Apologies for the breakage, and thanks for looking into the cause!
Could you identify whether both timeouts needed doubling, or just one of
them?

Thanks,
Ben.

> 
> My card is a GTX 280.
> 
> Regards,

  parent reply	other threads:[~2012-01-02 22:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-01 21:38 Bisect: i2c regression in 63daa9589cb88617d9cc8a0b0282564682a975b7 Vincent Pelletier
     [not found] ` <201201012238.25620.plr.vincent-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-01-02 22:40   ` Ben Skeggs [this message]
2012-01-03  8:22     ` Vincent Pelletier
2012-01-20 21:32     ` Vincent Pelletier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1325544010.8507.1.camel@nisroch \
    --to=bskeggs-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=plr.vincent-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.