All of lore.kernel.org
 help / color / mirror / Atom feed
From: Colin Walters <walters@verbum.org>
To: poky <poky@yoctoproject.org>
Subject: [PATCH] flex/bison: Don't hardcode M4 path
Date: Tue, 03 Jan 2012 18:50:27 -0500	[thread overview]
Message-ID: <1325634627.24646.0.camel@lenny> (raw)

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

The flex and bison configure scripts use AC_PATH_PROG to get a
full path to m4 and embed this in config.h (and then to the
generated binary), but this blows up when the m4 binary is in a
temporary staging directory.
    
Since we are always shipping GNU m4, just set M4=m4 at configure
time so we don't use a hardcoded path.
    
This is an equivalent to what already exists in autoconf.bb.


[-- Attachment #2: 0001-flex-bison-Don-t-hardcode-M4-path.patch --]
[-- Type: text/x-patch, Size: 2301 bytes --]

From d33924d0de58e25bce73e5b4d61983fe0c1d0119 Mon Sep 17 00:00:00 2001
From: Colin Walters <walters@verbum.org>
Date: Tue, 3 Jan 2012 18:47:32 -0500
Subject: [PATCH] flex/bison: Don't hardcode M4 path

The flex and bison configure scripts use AC_PATH_PROG to get a full
path to m4 and embed this in config.h (and then to the generated
binary), but this blows up when the m4 binary is in a temporary
staging directory.

Since we are always shipping GNU m4, just set M4=m4 at configure time
so we don't use a hardcoded path.

This is an equivalent to what already exists in autoconf.bb.
---
 meta/recipes-devtools/bison/bison_2.5.bb |   10 ++++------
 meta/recipes-devtools/flex/flex.inc      |    7 ++++---
 2 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/meta/recipes-devtools/bison/bison_2.5.bb b/meta/recipes-devtools/bison/bison_2.5.bb
index c5113cd..0536dd4 100644
--- a/meta/recipes-devtools/bison/bison_2.5.bb
+++ b/meta/recipes-devtools/bison/bison_2.5.bb
@@ -21,16 +21,14 @@ SRC_URI = "${BASE_SRC_URI} \
 SRC_URI[md5sum] = "687e1dcd29452789d34eaeea4c25abe4"
 SRC_URI[sha256sum] = "722def46e4a19a5b7a579ef30db1965f86c37c1a20a5f0113743a2e4399f7c99"
 
+# We don't want to hardcode the m4 path since it will be found
+# in the staging directory.
+EXTRA_OECONF = " M4=m4"
+
 DEPENDS_virtclass-native = "gettext-minimal-native"
 SRC_URI_virtclass-native = "${BASE_SRC_URI}"
 
 inherit autotools gettext
 acpaths = "-I ${S}/m4"
 
-do_install_append_virtclass-native() {
-	create_wrapper ${D}/${bindir}/bison \
-		M4=${STAGING_BINDIR_NATIVE}/m4 \
-		BISON_PKGDATADIR=${STAGING_DATADIR_NATIVE}/bison
-}
-#bison-native encodes the staging M4 path
 BBCLASSEXTEND = "native"
diff --git a/meta/recipes-devtools/flex/flex.inc b/meta/recipes-devtools/flex/flex.inc
index 01f7571..a913d21 100644
--- a/meta/recipes-devtools/flex/flex.inc
+++ b/meta/recipes-devtools/flex/flex.inc
@@ -10,6 +10,7 @@ SRC_URI = "${SOURCEFORGE_MIRROR}/flex/flex-${PV}.tar.bz2 "
 
 inherit autotools gettext
 
-do_install_append_virtclass-native() {
-	create_wrapper ${D}/${bindir}/flex M4=${STAGING_BINDIR_NATIVE}/m4
-}
+# We don't want to hardcode the m4 path since it will be found
+# in the staging directory.
+EXTRA_OECONF = " M4=m4"
+
-- 
1.7.6.4


             reply	other threads:[~2012-01-03 23:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-03 23:50 Colin Walters [this message]
2012-01-04  0:53 ` [poky] [PATCH] flex/bison: Don't hardcode M4 path Saul Wold
2012-01-04  0:53   ` Saul Wold
2012-01-04  2:20   ` [poky] " Colin Walters
2012-01-04  2:20     ` Colin Walters
2012-01-04 16:18     ` [poky] " Richard Purdie
2012-01-04 16:18       ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1325634627.24646.0.camel@lenny \
    --to=walters@verbum.org \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.