From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] insane.bbclass: use bb.process.Popen instead of subprocess.check_output
Date: Thu, 05 Jan 2012 22:21:15 +0000 [thread overview]
Message-ID: <1325802075.20759.78.camel@ted> (raw)
In-Reply-To: <7583e732bc226f24befcad605b4bfa0536a1ae3c.1325797875.git.scott.a.garman@intel.com>
On Thu, 2012-01-05 at 13:12 -0800, Scott Garman wrote:
> subprocess.check_output was only introduced in Python v2.7, so we
> cannot use it. This refactors the QA test to use bb.process.Popen
> instead.
>
> This fixes the error:
>
> AttributeError: 'module' object has no attribute 'check_output'
>
> It no longer checks the return status of prelink-rtld, as that
> case was simply adding noise. This QA test is intended to only
> warn about specific paths that binaries could be linking to, not
> handle the case where there is a missing library.
>
> Signed-off-by: Scott Garman <scott.a.garman@intel.com>
> ---
> meta/classes/insane.bbclass | 16 ++++++----------
> 1 files changed, 6 insertions(+), 10 deletions(-)
Merged to master, thanks for the quick fix!
Cheers,
Richard
prev parent reply other threads:[~2012-01-05 22:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 21:12 [PATCH 0/1] Urgent fix for insane.bbclass Scott Garman
2012-01-05 21:12 ` [PATCH 1/1] insane.bbclass: use bb.process.Popen instead of subprocess.check_output Scott Garman
2012-01-05 22:21 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1325802075.20759.78.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.