From: Avi Kivity <avi@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 1/3] vhost: fix incorrect userspace address
Date: Mon, 9 Jan 2012 14:04:52 +0200 [thread overview]
Message-ID: <1326110694-5196-2-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1326110694-5196-1-git-send-email-avi@redhat.com>
MemoryListener::region_add() gives us a slice of a MemoryRegion, not a
region. Adjust the userspace address to reflect that.
Signed-off-by: Avi Kivity <avi@redhat.com>
---
hw/vhost.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/vhost.c b/hw/vhost.c
index cd56e75..541c716 100644
--- a/hw/vhost.c
+++ b/hw/vhost.c
@@ -378,7 +378,7 @@ static void vhost_set_memory(MemoryListener *listener,
assert(size);
/* Optimize no-change case. At least cirrus_vga does this a lot at this time. */
- ram = memory_region_get_ram_ptr(section->mr);
+ ram = memory_region_get_ram_ptr(section->mr) + section->offset_within_region;
if (add) {
if (!vhost_dev_cmp_memory(dev, start_addr, size, (uintptr_t)ram)) {
/* Region exists with same address. Nothing to do. */
--
1.7.7.1
next prev parent reply other threads:[~2012-01-09 12:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 12:04 [Qemu-devel] [PATCH 0/3] Fix vhost after memory API breakage Avi Kivity
2012-01-09 12:04 ` Avi Kivity [this message]
2012-01-09 13:28 ` [Qemu-devel] [PATCH 1/3] vhost: fix incorrect userspace address Michael S. Tsirkin
2012-01-09 12:04 ` [Qemu-devel] [PATCH 2/3] vhost: fix mem_sections memory corruption Avi Kivity
2012-01-09 13:28 ` Michael S. Tsirkin
2012-01-09 12:04 ` [Qemu-devel] [PATCH 3/3] vhost: improve region filtering Avi Kivity
2012-01-09 13:28 ` Michael S. Tsirkin
2012-01-09 13:27 ` Avi Kivity
2012-01-09 13:32 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326110694-5196-2-git-send-email-avi@redhat.com \
--to=avi@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.