From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: [PATCH] ASoC: twl6040 - Add method to query optimum PDM_DL1 gain Date: Tue, 10 Jan 2012 11:03:09 +0000 Message-ID: <1326193389.3944.8.camel@odin> References: <1326111082-11678-1-git-send-email-lrg@ti.com> <20120110004428.GL30766@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from na3sys009aog114.obsmtp.com (na3sys009aog114.obsmtp.com [74.125.149.211]) by alsa0.perex.cz (Postfix) with ESMTP id 16FD02453A for ; Tue, 10 Jan 2012 12:03:27 +0100 (CET) Received: by mail-wi0-f174.google.com with SMTP id hm6so4414689wib.5 for ; Tue, 10 Jan 2012 03:03:12 -0800 (PST) In-Reply-To: <20120110004428.GL30766@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Tue, 2012-01-10 at 00:44 +0000, Mark Brown wrote: > On Mon, Jan 09, 2012 at 12:11:22PM +0000, Liam Girdwood wrote: > > The DL1 PDM interface adds a little gain depending on the output device. > > Add a method to retrieve the gain value for machine driver usage. > > I'm having a hard time understanding how the machine driver would use > this information... > It's intended that the machine driver would use this information to configure the ABE to compensate any attenuation so that the output volume level was constant. > > +int twl6040_get_dl1_gain(struct snd_soc_codec *codec) > > +{ > > + struct snd_soc_dapm_context *dapm = &codec->dapm; > > + > > + if (snd_soc_dapm_get_pin_status(dapm, "EP")) > > + return -1; /* -1dB */ > > Shouldn't this be being done by reading the CODEC register settings to > know which output DL1 is connected to? The DL1 path output devices can all operate at the same time and may or may not be connected by the machine drivers. Liam