Re: [PATCH] bitbake/fetch2: add support for wrapper command

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2012-01-12 at 17:09 -0600, Matthew McClintock wrote:
> cc: bitbake-devel@lists.openembedded.org
> Signed-off-by: Matthew McClintock <msm@freescale.com>
> ---
>  lib/bb/fetch2/__init__.py |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/lib/bb/fetch2/__init__.py b/lib/bb/fetch2/__init__.py
> index 3af56e5..1d7d5c7 100644
> --- a/lib/bb/fetch2/__init__.py
> +++ b/lib/bb/fetch2/__init__.py
> @@ -389,6 +389,8 @@ def runfetchcmd(cmd, d, quiet = False, cleanup = []):
>      Optionally remove the files/directories listed in cleanup upon failure
>      """
>  
> +    cmd = "%s %s" % (bb.data.getVar("BB_FETCH_WRAPPER", d, True), cmd)
> +
>      # Need to export PATH as binary could be in metadata paths
>      # rather than host provided
>      # Also include some other variables.

Er, this is going to break for anyone who doesn't have BB_FETCH_WRAPPER
set. It would be nice to document why you require this in the commit
message (I can guess). Since I'm rejecting this patch, can the next one
document the new variable in the fetcher section of bitbake manual too
please? :)

Cheers,

Richard