Re: [PATCH 2 of 3] libxl: allow for specifying the CPU affinity in the config file.

[Dario Faggioli <raistlin@linux.it>]

[-- Attachment #1.1: Type: text/plain, Size: 1714 bytes --]

On Fri, 2012-01-13 at 08:09 +0000, Ian Campbell wrote: 
> > Having this set to "none" here simplifies a bit the code when we came to
> > config file parsing (if I set it to "any CPU" here, I'll have to reset
> > to "none" before parsing). Also, default is exactly what you're
> > suggesting already, as I set the map to "any CPU" if no "cpus" config
> > option is found.
> 
> xl's default is "any CPU" but libxl's default is "no CPU" which will
> mean every toolstack author needs to do be aware of this even if they
> don't care about affinity.
> 
Ok, I think I see your point now, which I didn't in the first place, and
neither yesterday while replying. Sorry, my fault, I agree I need to set
it to "any CPU" right here.

> > Anyway, I guess I can do as you suggest if you really think it's
> > better. :-)
> 
> Please ;-)
> 
Sure, will do like that.

> > It is different, and that was intentional. What I wanted, was the syntax
> > to be exactly the same of `xl vcpu-pin', which is the command line
> > equivalent of this option, much more than cpupool-*. If you want, I
> > think I can easily enable list-like CPU specification as in cpupool
> > config file so that _both_ syntax are allowed. What do you think?
> 
> I think supporting both makes sense, we do something similar in a couple
> of places already.
> 
Ok then.

Thanks,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-------------------------------------------------------------------
Dario Faggioli, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
PhD Candidate, ReTiS Lab, Scuola Superiore Sant'Anna, Pisa (Italy)



[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel