All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Cc: Matthew McClintock <msm@freescale.com>
Subject: Re: [PATCH 1/2] bitbake/fetch2: add support for wrapper command
Date: Mon, 16 Jan 2012 12:32:39 +0000	[thread overview]
Message-ID: <1326717159.532.2.camel@ted> (raw)
In-Reply-To: <4F13AD3B.50902@linux.intel.com>

On Sun, 2012-01-15 at 20:53 -0800, Saul Wold wrote:
> On 01/12/2012 03:03 PM, Matthew McClintock wrote:
> > cc: bitbake-devel@lists.openembedded.org
> > Signed-off-by: Matthew McClintock<msm@freescale.com>
> > ---
> >   bitbake/lib/bb/fetch2/__init__.py |    2 ++
> >   1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/bitbake/lib/bb/fetch2/__init__.py b/bitbake/lib/bb/fetch2/__init__.py
> > index 3af56e5..1d7d5c7 100644
> > --- a/bitbake/lib/bb/fetch2/__init__.py
> > +++ b/bitbake/lib/bb/fetch2/__init__.py
> > @@ -389,6 +389,8 @@ def runfetchcmd(cmd, d, quiet = False, cleanup = []):
> >       Optionally remove the files/directories listed in cleanup upon failure
> >       """
> >
> > +    cmd = "%s %s" % (bb.data.getVar("BB_FETCH_WRAPPER", d, True), cmd)
> > +
> I am guessing you really want a check here if BB_FETCH_WRAPPER is set, 
> otherwise I am not sure this will work correctly, did you test without 
> this new variable set?

We've had this conversation on the bitbake list. I think Matthew has an
alternative fix to use instead of this so we'll likely drop this patch
anyway.

Cheers,

Richard




  reply	other threads:[~2012-01-16 12:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-12 23:03 [PATCH 1/2] bitbake/fetch2: add support for wrapper command Matthew McClintock
2012-01-12 23:03 ` [PATCH 2/2] " Matthew McClintock
2012-01-16  4:53 ` [PATCH 1/2] " Saul Wold
2012-01-16 12:32   ` Richard Purdie [this message]
2012-01-16 15:05     ` McClintock Matthew-B29882

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1326717159.532.2.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=msm@freescale.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.