Re: [PATCHv2 2 of 2] libxl: allow for specifying the CPU affinity in the config file.

[Dario Faggioli <raistlin@linux.it>]

[-- Attachment #1.1: Type: text/plain, Size: 1953 bytes --]

On Wed, 2012-01-25 at 10:28 +0000, Ian Campbell wrote: 
> > +int libxl_set_vcpuaffinity_all(libxl_ctx *ctx, uint32_t domid,
> > +                               unsigned int max_vcpus, libxl_cpumap *cpumap)
> > +{
> > +    int i, rc = 0;
> > +
> > +    for (i = 0; i < max_vcpus; i++) 
> > +        if (libxl_set_vcpuaffinity(ctx, domid, i, cpumap)) {
> > +            LIBXL__LOG(ctx, LIBXL__LOG_WARNING, "no affinity for cpu %d", i);
> 
> "failed to set affinity for ..." would better describe what had happened.
> 
Ok.

> > +static void print_bitmap(uint8_t *map, int maplen, FILE *stream)
> > +{
> [...]
> 
> I assumed this was pure code motion so I didn't read it.
> 
It is.

> > @@ -328,6 +384,9 @@ static void printf_info(int domid,
> >  
> >      printf("\t(build_info)\n");
> >      printf("\t(max_vcpus %d)\n", b_info->max_vcpus);
> > +    printf("\t(CPU affinity ");
> > +    print_bitmap(b_info->cpumap.map, nr_cpus, stdout);
> 
> If libxl_get_physinfo failed then nr_cpus would == -1 here.
> 
> However I don't think it is even necessary to extend this (legacy) sexp
> any further. I'm about to send a patch which will use the print the json
> representation (which is autogenerated).
> 
Ok, then I'll drop this.

> > +static int vcpupin_parse(char *cpu, libxl_cpumap *cpumap);
> 
> There are no calls to vcpupin_parse added after this point by this patch
> so is this necessary? I'd prefer moving the function up in any case or
> at least declaring all the forward references near the top of the file.
> 
Oops. I thought I removed all these fwd-decls. Sorry, seems this one
escaped... Will nuke it. :-)

Thanks,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-------------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)



[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel