All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rolf Eike Beer <eb@emlix.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Michal Marek <michal.lkml@markovi.net>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] objtool: query pkg-config for libelf location
Date: Wed, 20 Mar 2019 16:50:18 +0100	[thread overview]
Message-ID: <13279932.E8cnC9vheV@devpool35> (raw)
In-Reply-To: <20190320153701.7wym7btpjshdujpz@treble>

[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]

Josh Poimboeuf wrote:
> On Tue, Mar 19, 2019 at 08:20:12AM +0100, Rolf Eike Beer wrote:

> > diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile
> > index c9d038f91af6..0c8dd1609348 100644
> > --- a/tools/objtool/Makefile
> > +++ b/tools/objtool/Makefile
> > @@ -25,14 +25,17 @@ LIBSUBCMD		= $(LIBSUBCMD_OUTPUT)libsubcmd.a
> > 
> >  OBJTOOL    := $(OUTPUT)objtool
> >  OBJTOOL_IN := $(OBJTOOL)-in.o
> > 
> > +LIBELF_FLAGS = $(shell pkg-config libelf --cflags)
> > +LIBELF_LIBS = $(shell pkg-config libelf --libs 2>/dev/null || echo -lelf)
> 
> Should LIBELF_FLAGS also pipe stderr to /dev/null?

Probably. New version in a minute.

Thanks,

Eike
-- 
Rolf Eike Beer, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax +49 551 30664-11
Gothaer Platz 3, 37083 Göttingen, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
Geschäftsführung: Heike Jordan, Dr. Uwe Kracke – Ust-IdNr.: DE 205 198 055

emlix - smart embedded open source

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 313 bytes --]

  reply	other threads:[~2019-03-20 15:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-19  7:20 [PATCH] objtool: query pkg-config for libelf location Rolf Eike Beer
2019-03-20 15:37 ` Josh Poimboeuf
2019-03-20 15:50   ` Rolf Eike Beer [this message]
2019-03-20 15:58     ` [PATCH v2] " Rolf Eike Beer
2019-03-20 16:03       ` Josh Poimboeuf
  -- strict thread matches above, loose matches on Subject: below --
2019-03-26 17:48 [PATCH] objtool: Query " Josh Poimboeuf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13279932.E8cnC9vheV@devpool35 \
    --to=eb@emlix.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=peterz@infradead.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.