All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Blundell <philb@gnu.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [CONSOLIDATED PULL 16/19] tunearch/arm: Differentiate between thumb code generation and thumb capability
Date: Tue, 31 Jan 2012 10:48:37 +0000	[thread overview]
Message-ID: <1328006918.29933.91.camel@phil-desktop> (raw)
In-Reply-To: <79a999f69d58ca98393991d18d0efd274932ff56.1327980240.git.sgw@linux.intel.com>

On Mon, 2012-01-30 at 20:13 -0800, Saul Wold wrote:
> We have diverged a bit from oe.dev where thumb in OVERRIDES meant
> the code was being compiled in thumb mode. With tunearch this got
> a different meaning where it meant that if a core is capable of
> generating thumb code them we will have this in overrides. With this
> patch I am trying to address the problem where 'thumbmode' in TUNE_FEATURES
> means that code will be compiled in thumb mode by default and
> 'thumb' is to denote that core is capable of thumb instruction set.

So this patch is changing the meaning of the "thumb" override in
oe-core, right?  Is that really a good idea?

Also, I'm not quite sure I understand what the "thumb" tuning would be
useful for when this patch is applied.  You seem to have removed most of
the code which checks for "thumb" in TUNE_FEATURES which seems to leave
it not doing anything very much.

Can you clarify what exactly is the problem that this patch is solving,
what the old and new semantics of the overrides and tune flags are, and
why it's an improvement?

p.





  reply	other threads:[~2012-01-31 10:56 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-31  4:13 [CONSOLIDATED PULL 00/19] Community Chest Saul Wold
2012-01-31  4:13 ` [CONSOLIDATED PULL 01/19] default-providers: add kbd as PREFERRED_PROVIDER for console-tools Saul Wold
2012-01-31  4:13 ` [CONSOLIDATED PULL 02/19] gcc-runtime: fix override from poky-lsb to linuxstdbase Saul Wold
2012-01-31  4:13 ` [CONSOLIDATED PULL 03/19] rootfs_ipk: remove runtime_script_required usage Saul Wold
2012-01-31  4:13 ` [CONSOLIDATED PULL 04/19] image_types.bbclass: refactor cpio images generation Saul Wold
2012-01-31  4:13 ` [CONSOLIDATED PULL 05/19] genext2fs: fix inode computation Saul Wold
2012-01-31  4:13 ` [CONSOLIDATED PULL 06/19] qt4-tools-nativesdk-4.8.0: fix build Saul Wold
2012-01-31  4:13 ` [CONSOLIDATED PULL 07/19] alsa-state: fix RDEPENDS assignment Saul Wold
2012-01-31  4:13 ` [CONSOLIDATED PULL 08/19] alsa-utils: make alsa-utils-alsactl recommend alsa-states Saul Wold
2012-01-31  4:13 ` [CONSOLIDATED PULL 09/19] classes: replace 'Poky' with 'OE-core' Saul Wold
2012-01-31  4:13 ` [CONSOLIDATED PULL 10/19] tzdata_2011n: provide pkg_postinst and timezone defaults Saul Wold
2012-01-31  4:13 ` [CONSOLIDATED PULL 11/19] kern-tools: import config audit and branch manipulation updates Saul Wold
2012-01-31  4:13 ` [CONSOLIDATED PULL 12/19] linux-yocto: add kernel 3.2.2 support Saul Wold
2012-01-31  4:13 ` [CONSOLIDATED PULL 13/19] linux-yocto: update to v3.0.18 + features Saul Wold
2012-01-31  4:13 ` [CONSOLIDATED PULL 14/19] gdb-common: Drop elfutils from DEPENDS Saul Wold
2012-01-31  4:13 ` [CONSOLIDATED PULL 15/19] arm/tune: Correct the logic which added thumb-interwork to OVERRIDES Saul Wold
2012-01-31  4:13 ` [CONSOLIDATED PULL 16/19] tunearch/arm: Differentiate between thumb code generation and thumb capability Saul Wold
2012-01-31 10:48   ` Phil Blundell [this message]
2012-01-31 15:24     ` Khem Raj
2012-01-31  4:13 ` [CONSOLIDATED PULL 17/19] tune-thumb.inc: Delete Saul Wold
2012-01-31  4:13 ` [CONSOLIDATED PULL 18/19] libksba: add recipe for 1.2.0 Saul Wold
2012-01-31  4:13 ` [CONSOLIDATED PULL 19/19] gnupg: add recipe for 2.0.18 Saul Wold
2012-01-31 11:36 ` [CONSOLIDATED PULL 00/19] Community Chest Otavio Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1328006918.29933.91.camel@phil-desktop \
    --to=philb@gnu.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.