All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: linux-bluetooth <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH v3] Bluetooth: Fix l2cap conn failures for ssp devices
Date: Wed, 01 Feb 2012 16:12:37 -0800	[thread overview]
Message-ID: <1328141557.2054.0.camel@aeonflux> (raw)
In-Reply-To: <1312921615.2261.1.camel@THOR>

Hi Peter,

> Commit 330605423c fixed l2cap conn establishment for non-ssp remote
> devices by not setting HCI_CONN_ENCRYPT_PEND every time conn security
> is tested (which was always returning failure on any subsequent
> security checks).
> 
> However, this broke l2cap conn establishment for ssp remote devices
> when an ACL link was already established at SDP-level security. This
> fix ensures that encryption must be pending whenever authentication
> is also pending.
> 
> Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
> ---
> 
> v2: Avoids possible race condition between hci_conn_security and
> hci_conn_complete_evt
> v3: Actually compiles :)
> 
>  net/bluetooth/hci_conn.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Regards

Marcel



  parent reply	other threads:[~2012-02-02  0:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-09 20:26 [PATCH v3] Bluetooth: Fix l2cap conn failures for ssp devices Peter Hurley
2012-01-04 10:22 ` Daniel Wagner
2012-01-09  8:30   ` Daniel Wagner
2012-01-11 11:26     ` Johan Hedberg
2012-01-16 19:37       ` Peter Hurley
2012-01-17  8:27         ` Johan Hedberg
2012-01-17 12:34           ` Peter Hurley
2012-02-01 22:22             ` Luiz Augusto von Dentz
2012-02-02  0:12 ` Marcel Holtmann [this message]
2012-02-02  0:26   ` Johan Hedberg
2012-02-02  9:36     ` Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1328141557.2054.0.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=peter@hurleysoftware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.