From: George Dunlap <george.dunlap@citrix.com>
To: Andres Lagar-Cavilla <andres@lagarcavilla.org>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
"andres@gridcentric.ca" <andres@gridcentric.ca>,
"Tim (Xen.org)" <tim@xen.org>,
"keir.xen@gmail.com" <keir.xen@gmail.com>,
"adin@gridcentric.ca" <adin@gridcentric.ca>
Subject: Re: [PATCH 2 of 5] Clean up locking now that p2m lockups are fully synchronized
Date: Thu, 2 Feb 2012 14:31:22 +0000 [thread overview]
Message-ID: <1328193082.21722.31.camel@elijah> (raw)
In-Reply-To: <fb9c06df05f20461744a.1328126166@xdev.gridcentric.ca>
On Wed, 2012-02-01 at 19:56 +0000, Andres Lagar-Cavilla wrote:
> @@ -1445,7 +1449,7 @@ p2m_get_nestedp2m(struct vcpu *v, uint64
> nestedp2m_unlock(d);
> return p2m;
> }
> - p2m_unlock(p2m);
> + gfn_unlock(p2m, gfn, 0);
> }
It looks like maybe you forgot to change the corresponding p2m_lock() to
gfn_lock(), here in p2m.c:p2m_get_nestedp2m()?
Other than that, I think the PoD stuff looks fine. So regarding PoD
stuff:
Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
next prev parent reply other threads:[~2012-02-02 14:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 19:56 [PATCH 0 of 5] Synchronized p2m lookups Andres Lagar-Cavilla
2012-02-01 19:56 ` [PATCH 1 of 5] Make p2m lookups fully synchronized wrt modifications Andres Lagar-Cavilla
2012-02-02 13:08 ` Tim Deegan
2012-02-02 14:01 ` Andres Lagar-Cavilla
2012-02-01 19:56 ` [PATCH 2 of 5] Clean up locking now that p2m lockups are fully synchronized Andres Lagar-Cavilla
2012-02-02 13:10 ` Tim Deegan
2012-02-02 14:31 ` George Dunlap [this message]
2012-02-02 19:40 ` Andres Lagar-Cavilla
2012-02-01 19:56 ` [PATCH 3 of 5] Rework locking in the PoD layer Andres Lagar-Cavilla
2012-02-02 13:14 ` Tim Deegan
2012-02-02 14:04 ` Andres Lagar-Cavilla
2012-02-02 15:33 ` George Dunlap
2012-02-02 20:03 ` Andres Lagar-Cavilla
2012-02-01 19:56 ` [PATCH 4 of 5] Re-order calls to put_gfn() around wait queu invocations Andres Lagar-Cavilla
2012-02-02 13:26 ` Tim Deegan
2012-02-01 19:56 ` [PATCH 5 of 5] x86/mm: Revert changeset 24582:f6c33cfe7333 Andres Lagar-Cavilla
2012-02-02 13:27 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328193082.21722.31.camel@elijah \
--to=george.dunlap@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=adin@gridcentric.ca \
--cc=andres@gridcentric.ca \
--cc=andres@lagarcavilla.org \
--cc=keir.xen@gmail.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.