From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1RtHnd-00028i-RL for mharc-grub-devel@gnu.org; Fri, 03 Feb 2012 06:59:29 -0500 Received: from eggs.gnu.org ([140.186.70.92]:45798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RtHnb-00028c-5s for grub-devel@gnu.org; Fri, 03 Feb 2012 06:59:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RtHnX-00089e-4w for grub-devel@gnu.org; Fri, 03 Feb 2012 06:59:27 -0500 Received: from spam1.wiktel.com ([69.89.207.151]:46168) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RtHnW-00089P-RV for grub-devel@gnu.org; Fri, 03 Feb 2012 06:59:23 -0500 Received: from [172.16.0.253] (thief-pool2-121-14.mncable.net [24.225.121.14]) (authenticated bits=0) by spam1.wiktel.com (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id q13BxJYD003208; Fri, 3 Feb 2012 05:59:19 -0600 Subject: Re: [PATCH] Don't create grubenv on ZFS From: Richard Laager To: Vladimir =?UTF-8?Q?=27=CF=86-coder/phcoder=27?= Serbinenko In-Reply-To: <4F2BB548.5010106@gmail.com> References: <1328181390.3572.74.camel@watermelon.coderich.net> <4F2BB14C.8040207@gmail.com> <1328263657.17279.16.camel@watermelon.coderich.net> <4F2BB548.5010106@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-KYiB2pIKLtT4rJnZGwev" Date: Fri, 03 Feb 2012 05:59:19 -0600 Message-ID: <1328270359.5007.3.camel@watermelon.coderich.net> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 X-bounce-key: wiktel.com-1; rlaager@wiktel.com; 1328270360; 1bFW2RUOUbZJRlNPSqP+X2G6kL0; X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 69.89.207.151 Cc: grub-devel@gnu.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2012 11:59:28 -0000 --=-KYiB2pIKLtT4rJnZGwev Content-Type: multipart/mixed; boundary="=-yiR84mx8bOYQOFhRNREo" --=-yiR84mx8bOYQOFhRNREo Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I've attached an updated patch. I also noticed a whitespace inconsistency when looking at another case statement. I've attached a patch. Both patches are -p0 and have a ChangeLog entry (in a separate file, which I think is the convention). --=20 Richard --=-yiR84mx8bOYQOFhRNREo Content-Disposition: attachment; filename="zfs-no-grubenv.patch" Content-Type: text/x-patch; name="zfs-no-grubenv.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 LS0tIHV0aWwvZ3J1Yi1pbnN0YWxsLmluCTIwMTItMDItMDMgMDQ6MTY6MzYuMDMyMjY1MDAwIC0w NjAwDQorKysgdXRpbC9ncnViLWluc3RhbGwuaW4JMjAxMi0wMi0wMyAwNTozNTo1MC4zNjI2Mjgw MDAgLTA2MDANCkBAIC00NjksNyArNDY5LDEyIEBADQogZ3J1Yl9kZXZpY2U9ImAiJGdydWJfcHJv YmUiIC0tZGV2aWNlLW1hcD0iJHtkZXZpY2VfbWFwfSIgLS10YXJnZXQ9ZGV2aWNlICIke2dydWJk aXJ9ImAiIHx8IGV4aXQgMQ0KIA0KIGlmICEgdGVzdCAtZiAiJHtncnViZGlyfSIvZ3J1YmVudjsg dGhlbg0KLSAgICAiJGdydWJfZWRpdGVudiIgIiR7Z3J1YmRpcn0iL2dydWJlbnYgY3JlYXRlDQor ICAgIGNhc2UgImAiJGdydWJfcHJvYmUiIC0tdGFyZ2V0PWZzICIke2dydWJkaXJ9ImAiIGluDQor ICAgICAgICBidHJmcyB8IGNwaW9mcyB8IG5ld2MgfCBvZGMgfCByb21mcyB8IHNxdWFzaDQgfCB0 YXJmcyB8IHpmcykNCisJICAgIDs7DQorICAgICAgICAqKQ0KKyAgICAgICAgICAgICIkZ3J1Yl9l ZGl0ZW52IiAiJHtncnViZGlyfSIvZ3J1YmVudiBjcmVhdGUNCisgICAgZXNhYw0KIGZpDQogDQog IyBDcmVhdGUgdGhlIGNvcmUgaW1hZ2UuIEZpcnN0LCBhdXRvLWRldGVjdCB0aGUgZmlsZXN5c3Rl bSBtb2R1bGUuDQotLS0gL2Rldi9udWxsCTE5NzAtMDEtMDEgMDA6MDA6MDAuMDAwMDAwMDAwICsw MDAwDQorKysgQ2hhbmdlTG9nLnpmcy1uby1ncnViZW52CTIwMTItMDItMDMgMDU6NDk6MjcuOTc3 Mzc2MDAwIC0wNjAwDQpAQCAtMCwwICsxLDUgQEANCisyMDEyLTAyLTAzICBSaWNoYXJkIExhYWdl ciA8cmxhYWdlckB3aWt0ZWwuY29tPg0KKw0KKwkqIHV0aWwvZ3J1Yi1pbnN0YWxsLmluOiBEb24n dCBjcmVhdGUgYSBncnViZW52IGZpbGUgb24gZmlsZXN5c3RlbXMNCisJdG8gd2hpY2ggR1JVQiBj YW5ub3Qgd3JpdGUuDQorDQo= --=-yiR84mx8bOYQOFhRNREo Content-Disposition: attachment; filename="grub-install-whitespace.patch" Content-Type: text/x-patch; name="grub-install-whitespace.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 LS0tIC9kZXYvbnVsbAkxOTcwLTAxLTAxIDAwOjAwOjAwLjAwMDAwMDAwMCArMDAwMA0KKysrIENo YW5nZUxvZy5ncnViLWluc3RhbGwtd2hpdGVzcGFjZQkyMDEyLTAyLTAzIDA1OjUyOjUxLjQzOTk0 MjAwMCAtMDYwMA0KQEAgLTAsMCArMSw0IEBADQorMjAxMi0wMi0wMyAgUmljaGFyZCBMYWFnZXIg PHJsYWFnZXJAd2lrdGVsLmNvbT4NCisNCisJKiB1dGlsL2dydWItaW5zdGFsbC5pbjogRml4IHNv bWUgaW5jb25zaXN0ZW50IHdoaXRlc3BhY2UuDQorDQotLS0gdXRpbC9ncnViLWluc3RhbGwuaW4J MjAxMi0wMi0wMyAwNTo1MzozNi4wMzk0NjU3NjkgLTA2MDANCisrKyB1dGlsL2dydWItaW5zdGFs bC5pbgkyMDEyLTAyLTAzIDA1OjU0OjA0Ljc3MTY5NzAwMCAtMDYwMA0KQEAgLTQ4NiwxMyArNDg2 LDEzIEBADQogIyBmaWxlc3lzdGVtIHdpbGwgYmUgYWNjZXNzaWJsZSkuDQogcGFydG1hcF9tb2R1 bGU9DQogZm9yIHggaW4gYGVjaG8gIiR7Z3J1Yl9kZXZpY2V9IiB8IHhhcmdzICIkZ3J1Yl9wcm9i ZSIgLS1kZXZpY2UtbWFwPSIke2RldmljZV9tYXB9IiAtLXRhcmdldD1wYXJ0bWFwIC0tZGV2aWNl IDI+IC9kZXYvbnVsbGA7IGRvDQotICAgY2FzZSAiJHgiIGluDQotICAgICAgIG5ldGJzZCB8IG9w ZW5ic2QpIA0KLQkgICBwYXJ0bWFwX21vZHVsZT0iJHBhcnRtYXBfbW9kdWxlIHBhcnRfYnNkIjs7 DQotICAgICAgICIiKSA7Ow0KLSAgICAgICAqKQ0KLQkgICBwYXJ0bWFwX21vZHVsZT0iJHBhcnRt YXBfbW9kdWxlIHBhcnRfJHgiOzsNCi0gICBlc2FjDQorICAgIGNhc2UgIiR4IiBpbg0KKyAgICAg ICAgbmV0YnNkIHwgb3BlbmJzZCkNCisgICAgICAgICAgICBwYXJ0bWFwX21vZHVsZT0iJHBhcnRt YXBfbW9kdWxlIHBhcnRfYnNkIjs7DQorICAgICAgICAiIikgOzsNCisgICAgICAgICopDQorICAg ICAgICAgICAgcGFydG1hcF9tb2R1bGU9IiRwYXJ0bWFwX21vZHVsZSBwYXJ0XyR4Ijs7DQorICAg IGVzYWMNCiBkb25lDQogDQogIyBEZXZpY2UgYWJzdHJhY3Rpb24gbW9kdWxlLCBpZiBhbnkgKGx2 bSwgcmFpZCkuDQo= --=-yiR84mx8bOYQOFhRNREo-- --=-KYiB2pIKLtT4rJnZGwev Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAk8rzBEACgkQbfU6uV4fG8512QCfYh8NOPX0pvZ7qEILyTGNtEaa RiYAoLKaP3qGol8Ujc14XVJd0e8aOu2H =Wz52 -----END PGP SIGNATURE----- --=-KYiB2pIKLtT4rJnZGwev--