From: Phil Blundell <philb@gnu.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] u-boot inc: update inc file for newer u-boot versions
Date: Fri, 03 Feb 2012 22:53:23 +0000 [thread overview]
Message-ID: <1328309603.2716.197.camel@x121e.pbcl.net> (raw)
In-Reply-To: <7D46E86EC0A8354091174257B2FED10127649BE9@DFLE34.ent.ti.com>
On Fri, 2012-02-03 at 21:43 +0000, Maupin, Chase wrote:
> > +# no gnu_hash in uboot.bin, by design, so skip QA
> > +INSANE_SKIP_${PN} = True
>
> BTW, I believe I can remove this line since I didn't see any QA warnings when building without it. I have seen versions of u-boot.inc that use the INSANE_SKIP and versions that don't so I'm not sure what the right thing is here.
If uboot.bin is what the name suggests (i.e. a straight binary file
rather than an ELF image) then the GNU_HASH check will be inoperative
anyway and there is no need to skip it.
I'm also not entirely sure that setting INSANE_SKIP_xx to "True" is
going to have any useful effect. If I remember right the value of that
variable is meant to be a list of checks to skip and I don't think True
is going to match against anything there.
So, all in all I think you are probably correct that this line can be
safely deleted.
p.
next prev parent reply other threads:[~2012-02-03 23:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 21:37 [RFC PATCH 0/1] u-boot inc: update inc file for newer u-boot versions Chase Maupin
2012-02-03 21:37 ` [PATCH 1/1] " Chase Maupin
2012-02-03 21:43 ` Maupin, Chase
2012-02-03 22:53 ` Phil Blundell [this message]
2012-02-03 23:26 ` Saul Wold
2012-02-06 14:13 ` Maupin, Chase
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328309603.2716.197.camel@x121e.pbcl.net \
--to=philb@gnu.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.