From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1RtobQ-0001fJ-6h for mharc-grub-devel@gnu.org; Sat, 04 Feb 2012 18:01:04 -0500 Received: from eggs.gnu.org ([140.186.70.92]:42108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RtobN-0001eo-N0 for grub-devel@gnu.org; Sat, 04 Feb 2012 18:01:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RtobL-0003EX-J0 for grub-devel@gnu.org; Sat, 04 Feb 2012 18:01:01 -0500 Received: from spam1.wiktel.com ([69.89.207.151]:42825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RtobL-0003EN-Dh for grub-devel@gnu.org; Sat, 04 Feb 2012 18:00:59 -0500 Received: from [172.16.0.253] (thief-pool2-121-14.mncable.net [24.225.121.14]) (authenticated bits=0) by spam1.wiktel.com (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id q14N0ugb018966; Sat, 4 Feb 2012 17:00:56 -0600 Subject: Re: [PATCH] diskfilter: Treat an unrecognized RAID level as an error From: Richard Laager To: Vladimir =?UTF-8?Q?=27=CF=86-coder/phcoder=27?= Serbinenko In-Reply-To: <4F2DB177.8080303@gmail.com> References: <1328392877.5007.38.camel@watermelon.coderich.net> <4F2DB177.8080303@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-HrVUPeM8J6/ZIivvLrod" Date: Sat, 04 Feb 2012 17:00:55 -0600 Message-ID: <1328396455.5007.89.camel@watermelon.coderich.net> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 X-bounce-key: wiktel.com-1; rlaager@wiktel.com; 1328396456; alRon6Ff4Rq5kucc8v7NMDzyKCE; X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 69.89.207.151 Cc: The development of GNU GRUB X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Feb 2012 23:01:03 -0000 --=-HrVUPeM8J6/ZIivvLrod Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2012-02-04 at 23:30 +0100, Vladimir '=CF=86-coder/phcoder' Serbinen= ko wrote: > On 04.02.2012 23:01, Richard Laager wrote: > > disk/diskfilter.c: In function 'grub_diskfilter_make_raid': > > disk/diskfilter.c:847:21: error: 'totsize' may be used uninitialized in > > this function [-Werror=3Duninitialized] > > > > Perhaps my patch should use assert() instead of return NULL? > We don't use assert since assert failures are usually not fatal. And=20 > failing to boot just because some otherwise unused disk has a RAID-9=20 > isn't reasonable. Noted. I see now that Gr=C3=A9goire Sutre already submitted the same fix. I don't know how I missed that mail before. Sorry for the noise. At least I learned about GRUB's take on assert(). --=20 Richard --=-HrVUPeM8J6/ZIivvLrod Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAk8tuJ0ACgkQbfU6uV4fG861CQCguO0WNHeGRSLvun0XuAuIS78G IcgAoOtKG7tHDFjdl4AaGPFRKTCQFJM0 =/Rjr -----END PGP SIGNATURE----- --=-HrVUPeM8J6/ZIivvLrod--