From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Rtqrq-000714-Gc for mharc-grub-devel@gnu.org; Sat, 04 Feb 2012 20:26:10 -0500 Received: from eggs.gnu.org ([140.186.70.92]:36228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rtqro-00070y-13 for grub-devel@gnu.org; Sat, 04 Feb 2012 20:26:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rtqrm-00005N-Mp for grub-devel@gnu.org; Sat, 04 Feb 2012 20:26:07 -0500 Received: from spam1.wiktel.com ([69.89.207.151]:50486) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rtqrm-00005J-Gm for grub-devel@gnu.org; Sat, 04 Feb 2012 20:26:06 -0500 Received: from [172.16.0.253] (thief-pool2-121-14.mncable.net [24.225.121.14]) (authenticated bits=0) by spam1.wiktel.com (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id q151Q2uk008539; Sat, 4 Feb 2012 19:26:03 -0600 Subject: Re: [PATCH] Don't create grubenv on ZFS From: Richard Laager To: Jordan Uggla In-Reply-To: References: <1328181390.3572.74.camel@watermelon.coderich.net> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-n3uMNzHChWiHU4/QUfL9" Date: Sat, 04 Feb 2012 19:26:02 -0600 Message-ID: <1328405162.5007.258.camel@watermelon.coderich.net> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 X-bounce-key: wiktel.com-1; rlaager@wiktel.com; 1328405163; 2aTFueMs26zrVkVhhiwLkhxqoBA; X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 69.89.207.151 Cc: The development of GNU GRUB X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Feb 2012 01:26:09 -0000 --=-n3uMNzHChWiHU4/QUfL9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable You make good points. I don't have a problem with the idea that save_env should throw an error when it can't actually *save* the grubenv. So a better way to look at my problem is to say, "I don't want my grub.cfg to call save_env by default." This then becomes an downstream Ubuntu bug, because my grub.cfg is only calling save_env by default for recordfail. I've submitted a patch to Ubuntu which disables recordfail for these filesystems: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/913336/comments/7 So I withdraw zfs-no-grubenv.patch. --=20 Richard --=-n3uMNzHChWiHU4/QUfL9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAk8t2qAACgkQbfU6uV4fG84T5gCcDZqg12EjCoj9ft3crYYM6LcN 42UAoNDJyKTWKeLY6JMT9tfjSl8Zru1t =Tfs7 -----END PGP SIGNATURE----- --=-n3uMNzHChWiHU4/QUfL9--