All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Stephane Eranian <eranian@google.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Markus Trippelsdorf <markus@trippelsdorf.de>,
	linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>
Subject: Re: WARNING: at arch/x86/kernel/cpu/perf_event.c:989
Date: Mon, 06 Feb 2012 21:58:10 +0100	[thread overview]
Message-ID: <1328561890.2482.39.camel@laptop> (raw)
In-Reply-To: <CABPqkBQPYvEu58TDPwDNV-ydpooe-yY924w4FnsEiK9DKEdJ2Q@mail.gmail.com>

On Mon, 2012-02-06 at 21:44 +0100, Stephane Eranian wrote:
> Which is pointing to the Intel specific:
> 
> intel_pmu_handle_irq()
> again:
>         intel_pmu_ack_status(status);
>         if (++loops > 100) {
>                 WARN_ONCE(1, "perfevents: irq loop stuck!\n");
>                 perf_event_print_debug();
>                 intel_pmu_reset();
>                 goto done;
>         }
> 
> We are in a constant interrupt loop for a reason I don't yet understand.
> Sure we have two counters going, bu given the callstack, one is being
> stopped.
> 
> I know we talked about that a couple of weeks back, but after all, it may
> be that it is not possible to run the frequency adjustment code without
> stopping the entire PMU because of risk of interrupts. But it is not clear
> to me what's causing this at this point.

There's Errata's on this, see AAK157 (SNB) BD106 (WSM) AAK157 (NHM).

Ingo and I talked about a 'fix' for that based on the text in the SNB
errata which explains why the reset works. Ingo I was under the
impression you were going to implement that?

> I suggest we still apply my patch to fix the x86_pmu_start() first, then
> I will submit a second patch to fix that one. Agreed? 

Yes.


  reply	other threads:[~2012-02-06 20:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-02 21:17 WARNING: at arch/x86/kernel/cpu/perf_event.c:989 Markus Trippelsdorf
2012-02-02 21:32 ` Markus Trippelsdorf
2012-02-02 22:22   ` Stephane Eranian
2012-02-04 13:51     ` Ingo Molnar
2012-02-04 18:09       ` Stephane Eranian
2012-02-06  9:54         ` Stephane Eranian
2012-02-06 10:12           ` Eric Dumazet
2012-02-06 10:40             ` Stephane Eranian
2012-02-06 11:11               ` Eric Dumazet
2012-02-06 14:13                 ` Stephane Eranian
2012-02-06 14:29                   ` Peter Zijlstra
2012-02-06 14:32                     ` Stephane Eranian
2012-02-06 15:02                       ` Peter Zijlstra
2012-02-06 14:38                   ` Ingo Molnar
2012-02-06 14:41                     ` Stephane Eranian
2012-02-06 15:47                       ` Ingo Molnar
2012-02-06 20:44                         ` Stephane Eranian
2012-02-06 20:58                           ` Peter Zijlstra [this message]
2012-02-06 21:25                             ` Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1328561890.2482.39.camel@laptop \
    --to=a.p.zijlstra@chello.nl \
    --cc=eranian@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus@trippelsdorf.de \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.