From: Ashish Jangam <ashish.jangam@kpitcummins.com>
To: <akpm@linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>, <sameo@linux.intel.com>,
<p_gortmaker@yahoo.com>, <dchen@diasemi.com>
Subject: Re: [PATCH 06/07] RTC: RTC driver for DA9052/53 PMIC v1
Date: Tue, 7 Feb 2012 17:55:02 +0530 [thread overview]
Message-ID: <1328617502.30549.91.camel@dhruva> (raw)
In-Reply-To: <C3AE124F08223B42BC95AEB82F0F6CED1FDDA892@KCHJEXMB02.kpit.com>
On Tue, 2012-02-07 at 17:51 +0530, Ashish Jangam wrote:
> I assume that this patch is mergeable without any of the other six
> patches in this series. It compiles OK...
yes
>
> > +{
> > + int ret;
> > + uint8_t v[5] = {0, 0, 0, 0, 0};
>
> These initalised local arrays are expensive. The below patch reduces
> the module's text size by over 100 bytes.
>
> The arrays whcih are passed to da9052_group_write() surely didn't need
> initalisation, and I trust that's also the case with the arrays which
> are passed to da9052_group_read()?
Correct, they can be passed without initialisation.
next parent reply other threads:[~2012-02-07 12:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <C3AE124F08223B42BC95AEB82F0F6CED1FDDA892@KCHJEXMB02.kpit.com>
2012-02-07 12:25 ` Ashish Jangam [this message]
2012-02-06 12:49 [PATCH 06/07] RTC: RTC driver for DA9052/53 PMIC v1 Ashish Jangam
2012-02-06 22:38 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328617502.30549.91.camel@dhruva \
--to=ashish.jangam@kpitcummins.com \
--cc=akpm@linux-foundation.org \
--cc=dchen@diasemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p_gortmaker@yahoo.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.