From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH 1/3] Device isolation group infrastructure (v3) Date: Thu, 09 Feb 2012 08:39:28 +1100 Message-ID: <1328737168.2903.35.camel@pasglop> References: <1328071614-8320-1-git-send-email-david@gibson.dropbear.id.au> <1328071614-8320-2-git-send-email-david@gibson.dropbear.id.au> <20120208152748.GD22598@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120208152748.GD22598-5C7GfCeVMHo@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Joerg Roedel Cc: kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, aik-sLpHqDYs0B2HXe+LvDLADg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, David Gibson List-Id: iommu@lists.linux-foundation.org On Wed, 2012-02-08 at 16:27 +0100, Joerg Roedel wrote: > Again, device grouping is done by the IOMMU drivers, so this all > belongs > into the generic iommu-code rather than the driver core. Except that there isn't really a "generic iommu code"... discovery, initialization & matching of iommu vs. devices etc... that's all implemented in the arch specific iommu code. Cheers, Ben. > I think it makes sense to introduce a device->iommu pointer which > depends on CONFIG_IOMMU_API and put the group information into it. > This also has the benefit that we can consolidate all the > device->arch.iommu pointers into device->iommu as well. > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757372Ab2BHVkG (ORCPT ); Wed, 8 Feb 2012 16:40:06 -0500 Received: from gate.crashing.org ([63.228.1.57]:58007 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107Ab2BHVkE (ORCPT ); Wed, 8 Feb 2012 16:40:04 -0500 Message-ID: <1328737168.2903.35.camel@pasglop> Subject: Re: [PATCH 1/3] Device isolation group infrastructure (v3) From: Benjamin Herrenschmidt To: Joerg Roedel Cc: David Gibson , dwmw2@infradead.org, iommu@lists.linux-foundation.org, aik@ozlabs.ru, qemu-devel@nongnu.org, alex.williamson@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 09 Feb 2012 08:39:28 +1100 In-Reply-To: <20120208152748.GD22598@amd.com> References: <1328071614-8320-1-git-send-email-david@gibson.dropbear.id.au> <1328071614-8320-2-git-send-email-david@gibson.dropbear.id.au> <20120208152748.GD22598@amd.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2012-02-08 at 16:27 +0100, Joerg Roedel wrote: > Again, device grouping is done by the IOMMU drivers, so this all > belongs > into the generic iommu-code rather than the driver core. Except that there isn't really a "generic iommu code"... discovery, initialization & matching of iommu vs. devices etc... that's all implemented in the arch specific iommu code. Cheers, Ben. > I think it makes sense to introduce a device->iommu pointer which > depends on CONFIG_IOMMU_API and put the group information into it. > This also has the benefit that we can consolidate all the > device->arch.iommu pointers into device->iommu as well. > > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvFFF-0003J4-TL for qemu-devel@nongnu.org; Wed, 08 Feb 2012 16:40:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvFFB-00078n-GO for qemu-devel@nongnu.org; Wed, 08 Feb 2012 16:40:05 -0500 Received: from gate.crashing.org ([63.228.1.57]:45779) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvFFA-00078K-Pc for qemu-devel@nongnu.org; Wed, 08 Feb 2012 16:40:01 -0500 Message-ID: <1328737168.2903.35.camel@pasglop> From: Benjamin Herrenschmidt Date: Thu, 09 Feb 2012 08:39:28 +1100 In-Reply-To: <20120208152748.GD22598@amd.com> References: <1328071614-8320-1-git-send-email-david@gibson.dropbear.id.au> <1328071614-8320-2-git-send-email-david@gibson.dropbear.id.au> <20120208152748.GD22598@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/3] Device isolation group infrastructure (v3) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Joerg Roedel Cc: kvm@vger.kernel.org, aik@ozlabs.ru, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, qemu-devel@nongnu.org, alex.williamson@redhat.com, dwmw2@infradead.org, David Gibson On Wed, 2012-02-08 at 16:27 +0100, Joerg Roedel wrote: > Again, device grouping is done by the IOMMU drivers, so this all > belongs > into the generic iommu-code rather than the driver core. Except that there isn't really a "generic iommu code"... discovery, initialization & matching of iommu vs. devices etc... that's all implemented in the arch specific iommu code. Cheers, Ben. > I think it makes sense to introduce a device->iommu pointer which > depends on CONFIG_IOMMU_API and put the group information into it. > This also has the benefit that we can consolidate all the > device->arch.iommu pointers into device->iommu as well. > >