All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: pcm: If pmdown_time is zero then shut down DAPM immediately
Date: Thu, 09 Feb 2012 08:33:05 +0000	[thread overview]
Message-ID: <1328776385.3951.1.camel@odin> (raw)
In-Reply-To: <1328731884-12468-1-git-send-email-broonie@opensource.wolfsonmicro.com>

On Wed, 2012-02-08 at 20:11 +0000, Mark Brown wrote:
> Since we've already got logic to special case immediate teardown of the
> stream we may as well use it if the pmdown_time has been set to zero by
> the application layer instead of scheduling a work item with zero delay.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  sound/soc/soc-pcm.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
> index ef28dd5..d7bb268 100644
> --- a/sound/soc/soc-pcm.c
> +++ b/sound/soc/soc-pcm.c
> @@ -369,7 +369,7 @@ static int soc_pcm_close(struct snd_pcm_substream *substream)
>  	cpu_dai->runtime = NULL;
>  
>  	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
> -		if (codec->ignore_pmdown_time ||
> +		if (!rtd->pmdown_time || codec->ignore_pmdown_time ||
>  		    rtd->dai_link->ignore_pmdown_time) {
>  			/* powered down playback stream now */
>  			snd_soc_dapm_stream_event(rtd,

Acked-by: Liam Girdwood <lrg@ti.com>

      reply	other threads:[~2012-02-09  8:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-08 20:11 [PATCH] ASoC: pcm: If pmdown_time is zero then shut down DAPM immediately Mark Brown
2012-02-09  8:33 ` Liam Girdwood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1328776385.3951.1.camel@odin \
    --to=lrg@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.