From: Joerg Roedel <joerg.roedel@amd.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Ingo Molnar <mingo@elte.hu>, Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
Jason Wang <jasowang@redhat.com>,
Joerg Roedel <joerg.roedel@amd.com>
Subject: [PATCH 2/2] perf-tool: Change perf_guest default back to false
Date: Fri, 10 Feb 2012 18:05:05 +0100 [thread overview]
Message-ID: <1328893505-4115-3-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1328893505-4115-1-git-send-email-joerg.roedel@amd.com>
Setting perf_guest to true by default makes no sense because
the perf subcommands can not setup guest symbol information
and thus not process and guest samples. The only exception
is perf-kvm which changes the perf_guest value on its own.
So change the default for perf_guest back to false.
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
tools/perf/util/util.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
index 8131410..fb25d13 100644
--- a/tools/perf/util/util.c
+++ b/tools/perf/util/util.c
@@ -6,7 +6,7 @@
* XXX We need to find a better place for these things...
*/
bool perf_host = true;
-bool perf_guest = true;
+bool perf_guest = false;
void event_attr_init(struct perf_event_attr *attr)
{
--
1.7.5.4
next prev parent reply other threads:[~2012-02-10 17:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 17:05 [PATCH 0/2 v2] Fix perf-tool crashes when kvm guest is running Joerg Roedel
2012-02-10 17:05 ` [PATCH 1/2] perf-tool: Don't process samples with no valid machine object Joerg Roedel
2012-02-17 9:47 ` [tip:perf/core] perf top: Don' t " tip-bot for Joerg Roedel
2012-02-10 17:05 ` Joerg Roedel [this message]
2012-02-17 9:47 ` [tip:perf/core] perf tools: Change perf_guest default back to false tip-bot for Joerg Roedel
2012-03-05 8:38 ` tip-bot for Joerg Roedel
-- strict thread matches above, loose matches on Subject: below --
2012-02-09 16:07 [PATCH 0/2] Fix perf-tool crashes when kvm guest is running Joerg Roedel
2012-02-09 16:07 ` [PATCH 2/2] perf-tool: Change perf_guest default back to false Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328893505-4115-3-git-send-email-joerg.roedel@amd.com \
--to=joerg.roedel@amd.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.