Re: [PATCH 4/5] OMAPDSS: Export functions to enable dynamic linking

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]

Hi,

On Sat, 2012-02-11 at 17:55 -0600, Ricardo Neri wrote:
> The functions dss_init_hdmi_ip_ops and dss_has_feature are used by
> the ASoC HDMI codec. Both the ASoC codec and DSS may be built
> as separate kernel modules. Hence, these two functions need to be
> available for dynamic linking.

Neither of those functions should be exported, they are omapdss
internal. And you had to hack around to make those usable by adding
drivers/video/omap2/dss into the include path.

Anything that is exported from omapdss should be added to
include/video/omapdss.h. Users of omapdss should never include anything
from drivers/video/omap2/dss.

But as I said, neither of those functions should be exported, they are
clearly omapdss internal functions. For dss_has_feature we probably need
a new function to convey the information about the hdmi features that
the audio side needs. Or perhaps it can be in the ip_data.

For dss_init_hdmi_ip_ops I don't see why the audio part should see it.
Initializing the ops should clearly be done by omapdss automatically.

 Tomi


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]