All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Joe Perches <joe@perches.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: RTLWIFI_DEBUG bug
Date: Tue, 14 Feb 2012 08:36:36 +0100	[thread overview]
Message-ID: <1329204996.3941.0.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4F398466.6010607@lwfinger.net> (sfid-20120213_224545_739603_39CB7C5F)

On Mon, 2012-02-13 at 15:45 -0600, Larry Finger wrote:
> On 02/13/2012 08:13 AM, Johannes Berg wrote:
> > config RTLWIFI_DEBUG
> >          tristate "Additional debugging output"
> >          depends on RTL8192CE || RTL8192CU || RTL8192SE || RTL8192DE
> >          default y
> >
> > should be
> >
> > config RTLWIFI_DEBUG
> >          bool "..."
> >
> > as otherwise
> >
> > +#ifdef CONFIG_RTLWIFI_DEBUG
> >
> > can never be true in a modular build.
> >
> > johannes
> 
> Johannes,
> 
> It is OK as is. The appropriate section of my .config has
> 
> CONFIG_RTL8192CE=m
> CONFIG_RTL8192SE=m
> CONFIG_RTL8192DE=m
> CONFIG_RTL8192CU=m
> CONFIG_RTLWIFI=m
> CONFIG_RTLWIFI_DEBUG=m

Kconfig wise it is fine, but you might as well unset it -- the only use
is an #ifdef which will not match when it's set to m.

johannes


      reply	other threads:[~2012-02-14  7:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-13 14:13 RTLWIFI_DEBUG bug Johannes Berg
2012-02-13 20:35 ` Joe Perches
2012-02-13 21:07   ` Johannes Berg
2012-02-14  1:48     ` Joe Perches
2012-02-13 21:45 ` Larry Finger
2012-02-14  7:36   ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329204996.3941.0.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=Larry.Finger@lwfinger.net \
    --cc=joe@perches.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.