From: Ben Hutchings <ben@decadent.org.uk>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: linux-kernel@vger.kernel.org, Michal Marek <mmarek@suse.cz>,
maximilian attems <max@stro.at>,
debian-kernel@lists.debian.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v2] kbuild: Fix link to headers in 'make deb-pkg'
Date: Wed, 15 Feb 2012 13:47:29 +0000 [thread overview]
Message-ID: <1329313649.3048.72.camel@deadeye> (raw)
In-Reply-To: <20120215112009.GD2238@amd.com>
[-- Attachment #1: Type: text/plain, Size: 1410 bytes --]
On Wed, 2012-02-15 at 12:20 +0100, Joerg Roedel wrote:
> On Tue, Feb 14, 2012 at 02:49:13AM +0000, Ben Hutchings wrote:
> > On Mon, 2012-02-13 at 15:48 +0100, Joerg Roedel wrote:
> > > The Link to the kernel header files in the debian packages
> > > point to the original build directory. This is a bad choice
> > > if the packages were installed on a different machine. Fix
> > > this in by manually re-creating the link in the builddeb
> > > script.
> > >
> > > Cc: Michal Marek <mmarek@suse.cz>
> > > Cc: maximilian attems <max@stro.at>
> > > Cc: Ben Hutchings <ben@decadent.org.uk>
> > > Cc: debian-kernel@lists.debian.org
> > > Cc: linux-kbuild@vger.kernel.org
> > > Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> >
> > This looks good for !UML.
> >
> > I wonder about the UML case though. Did you test it? In 3.3-rc3,
> > 'make headers_install' is broken. But if I suppress the header check,
> > the resulting packages have links in the right places.
>
> I havn't tested UML, I am not really familiar with using it. You are
> probably right that for UML only the linux-image package is needed. I
> can remove the UML check from this patch and post another one which
> changes the script to only build linux-image for UML, how does that
> sound?
Sounds good to me.
Ben.
--
Ben Hutchings
Beware of programmers who carry screwdrivers. - Leonard Brandwein
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2012-02-15 13:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 14:48 [PATCH v2] kbuild: Fix link to headers in 'make deb-pkg' Joerg Roedel
2012-02-13 14:48 ` Joerg Roedel
2012-02-14 2:49 ` Ben Hutchings
2012-02-15 11:20 ` Joerg Roedel
2012-02-15 11:20 ` Joerg Roedel
2012-02-15 13:47 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329313649.3048.72.camel@deadeye \
--to=ben@decadent.org.uk \
--cc=debian-kernel@lists.debian.org \
--cc=joerg.roedel@amd.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max@stro.at \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.