All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Andre Guedes <andre.guedes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC 3/4] Bluetooth: Merge INQUIRY and LE_SCAN discovery states
Date: Fri, 17 Feb 2012 09:50:06 +0100	[thread overview]
Message-ID: <1329468606.28848.140.camel@aeonflux> (raw)
In-Reply-To: <1329429041-30715-4-git-send-email-andre.guedes@openbossa.org>

Hi Andre,

> This patch merges DISCOVERY_INQUIRY and DISCOVERY_LE_SCAN states
> into a new state called DISCOVERY_FINDING.
> 
> From the discovery perspective, we are pretty much worried about
> to know just if we are finding devices than what exactly phase of
> "finding devices" (inquiry or LE scan) we are currently running.
> Besides, to know if the controller is performing inquiry or LE scan
> we should check HCI_INQUIRY or HCI_LE_SCAN bits in hdev flags.
> 
> Moreover, merging this two states will simplify the discovery state
> machine and will keep interleaved discovery implementation simpler.
> 
> Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
> ---
>  include/net/bluetooth/hci_core.h |    3 +--
>  net/bluetooth/hci_core.c         |    6 ++----
>  net/bluetooth/hci_event.c        |    6 +++---
>  net/bluetooth/mgmt.c             |    2 +-
>  4 files changed, 7 insertions(+), 10 deletions(-)

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Regards

Marcel



  reply	other threads:[~2012-02-17  8:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-16 21:50 [RFC 0/4] MGMT Start Discovery interleaved support Andre Guedes
2012-02-16 21:50 ` [RFC 1/4] Bluetooth: Prepare start_discovery Andre Guedes
2012-02-16 22:15   ` Johan Hedberg
2012-02-16 23:30     ` Andre Guedes
2012-02-17  8:44       ` Marcel Holtmann
2012-02-17  8:43   ` Marcel Holtmann
2012-02-16 21:50 ` [RFC 2/4] Bluetooth: Track discovery type Andre Guedes
2012-02-17  8:50   ` Marcel Holtmann
2012-02-16 21:50 ` [RFC 3/4] Bluetooth: Merge INQUIRY and LE_SCAN discovery states Andre Guedes
2012-02-17  8:50   ` Marcel Holtmann [this message]
2012-02-16 21:50 ` [RFC 4/4] Bluetooth: Interleaved discovery support Andre Guedes
2012-02-16 22:12   ` Johan Hedberg
2012-02-16 23:30     ` Andre Guedes
2012-02-17  8:48       ` Marcel Holtmann
2012-02-17 14:52         ` Johan Hedberg
2012-02-17 15:00           ` Johan Hedberg
2012-02-17 15:23             ` Ulisses Furquim
2012-02-17 15:25             ` Ulisses Furquim
2012-02-17 16:03           ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329468606.28848.140.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=andre.guedes@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.