From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Whitehouse Date: Fri, 17 Feb 2012 15:23:12 +0000 Subject: [Cluster-devel] [GFS2 PATCH] In-Reply-To: <1db268c1-f95d-4f29-bbdb-87e266e600ab@zmail12.collab.prod.int.phx2.redhat.com> References: <1db268c1-f95d-4f29-bbdb-87e266e600ab@zmail12.collab.prod.int.phx2.redhat.com> Message-ID: <1329492192.2735.54.camel@menhir> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, On Fri, 2012-02-17 at 09:34 -0500, Bob Peterson wrote: > ----- Original Message ----- > | Hi, > | > | If we are going to do this, then perhaps we should consider reading > | in > | the rindex on mount? That way it will always be uptodate, and we can > | refuse to mount if the rindex is damaged which is probably cleaner > | than > | doing it after the event. > | > | The only concern is the time taken to mount large filesystems. Having > | said that the rindex should be contiguous on disk in most cases, so > | it > | should be a fairly fast operation. Worth considering, anyway I think, > | > | Steve. > > Hi, > > That's not a bad idea, and we should consider it for a future enhancement. > However, I think these checks still need to be here because there are > other ways the rindex can get out of date and need to be re-read after > mount. For example, if there was another intermediate gfs2_grow done on a > different node. > > BTW, I assume you saw my other patch from yesterday regarding gfs2_unlink, right? > > Regards, > > Bob Peterson > Red Hat File Systems Both patches now pushed to the -nmw tree, but I'd like to see a more comprehensive fix for this in due course, Steve.