From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jorgyano Vieira <jorgyano@gmail.com>,
gregkh@linuxfoundation.org, devel@linuxdriverproject.org,
jarod@wilsonet.com, nsankar@broadcom.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr_err
Date: Fri, 17 Feb 2012 22:30:25 -0800 [thread overview]
Message-ID: <1329546625.1753.7.camel@joe2Laptop> (raw)
In-Reply-To: <20120218062534.GB2855@mwanda>
On Sat, 2012-02-18 at 09:25 +0300, Dan Carpenter wrote:
> On Fri, Feb 17, 2012 at 09:39:36PM -0200, Jorgyano Vieira wrote:
> > Replace the usage of BCMLOG_ERR with pr_err and remove the macro definition.
> This needs a pr_fmt line so we can tell where the errors are coming
> from.
> #define pr_fmt(fmt) KBUILD_MODNAME ": %s:%d: " fmt, __func__, __LINE__
True.
__func__ and __LINE__ are not generally useful though.
I suggest just
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
next prev parent reply other threads:[~2012-02-18 6:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 23:39 [PATCH 3/3] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr_err Jorgyano Vieira
2012-02-18 6:25 ` Dan Carpenter
2012-02-18 6:30 ` Joe Perches [this message]
2012-02-18 6:40 ` Dan Carpenter
2012-02-18 6:56 ` Joe Perches
2012-02-18 13:36 ` Jorgyano vieira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329546625.1753.7.camel@joe2Laptop \
--to=joe@perches.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jarod@wilsonet.com \
--cc=jorgyano@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nsankar@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.