All of lore.kernel.org
 help / color / mirror / Atom feed
From: "WXbet" <WXbet@proton.me>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] kernel: use absolute paths in the kernel-image scripts
Date: Wed, 30 Sep 2026 10:54:20 -0700	[thread overview]
Message-ID: <1329699.1790790860483693246@lists.openembedded.org> (raw)
In-Reply-To: <96d7662de4f754571942df16f9944fa8ce13a0f7.camel@pbarker.dev>

[-- Attachment #1: Type: text/plain, Size: 1730 bytes --]

Hi Paul,

On Sat, 2026-09-26, Paul Barker wrote:
> This describes two issues, we shouldn't just fix one of them. We should
> also fix the on-target postinst script relying on a command that is by
> default missing if you use busybox.
>
> I think should just enable CONFIG_INSTALL in the busybox defconfig.

Agreed, I'll include that in v2.

> I think the solution is to use an absolute path for this variable in
> kernel.bbclass. Then the rest of this patch becomes unnecessary

I looked into this. Changing the default alone breaks the build:
kernel.bbclass and kernel-devicetree.bbclass prefix the variable with
'/' in FILES:

kernel.bbclass:121    '/' + imagedest + '/' + type + ...
kernel.bbclass:685    /${KERNEL_IMAGEDEST}/System.map* ...
kernel.bbclass:686    /${KERNEL_IMAGEDEST}/vmlinux-...
kernel-devicetree.bbclass:17-21  /${KERNEL_DTBDEST}/... (defaults to
${KERNEL_IMAGEDEST})

With "/boot" these become "//boot/...", which populate_packages rejects
with files-invalid. That check is in CHECKLAYER_REQUIRED_TESTS, so it
is an error by default.

We can drop the '/' prefix in oe-core, but BSP layers that write
"/${KERNEL_IMAGEDEST}" in their own FILES or do_install and keep the
default would then fail with the same QA error. That pattern is common
because it is what oe-core itself uses today.

So I see two options for v2:

1) Keep the fix in the postinst/postrm scripts as in v1, plus the
busybox patch. No change for layers.

2) KERNEL_IMAGEDEST ?= "/boot", drop the '/' prefix in the FILES
entries in oe-core, plus the busybox patch, and a migration note
for layers that use "/${KERNEL_IMAGEDEST}" in FILES.

Which one would you prefer?

Best regards,
WXbet

[-- Attachment #2: Type: text/html, Size: 2197 bytes --]

      reply	other threads:[~2026-09-30 17:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14 18:21 [PATCH] kernel: use absolute paths in the kernel-image scripts WXbet
2026-09-26 15:01 ` Paul Barker
2026-09-30 17:54   ` WXbet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329699.1790790860483693246@lists.openembedded.org \
    --to=wxbet@proton.me \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.