All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Jason Baron <jbaron@redhat.com>,
	rostedt@goodmis.org, mathieu.desnoyers@efficios.com,
	mingo@elte.hu, davem@davemloft.net, ddaney.cavm@gmail.com,
	pjt@google.com, rth@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4][RFC] jump label: introduce default true branch
Date: Mon, 20 Feb 2012 23:51:41 +0100	[thread overview]
Message-ID: <1329778301.2293.379.camel@twins> (raw)
In-Reply-To: <4F42CD93.2030605@zytor.com>

On Mon, 2012-02-20 at 14:47 -0800, H. Peter Anvin wrote:
> On 12/21/2011 11:09 AM, Jason Baron wrote:
> > Hi Peter,
> > 
> > I've introduced a new static_branch_def_true() construct, such that the straight
> > line path is the true branch, and we patch a jump to get to the false branch.
> > In order to make jump_label_inc()/dec() work as 'make true'/'make false' with
> > counting, I've had to update some of the core jump label code. This patchset also
> > introduces: JUMP_LABEL_INIT_TRUE/FALSE, so that keys should be initialized as:
> > 
> > struct jump_label_key true_key = JUMP_LABEL_INIT_TRUE;
> > 
> >            or
> > 
> > struct jump_label_key false_key = JUMP_LABEL_INIT_FALSE;
> > 
> > I think this patch series should address the issues that came up with sched_feat()
> > implementation.
> > 
> 
> Hi,
> 
> Did this ever get addressed?

I actually tried to push that stuff to Ingo, he figured it all should
have different names. Jason and Ingo went back and forth for a while and
afaik settled on something. Jason then went off to implement, but I
haven't yet seen a new version.



  reply	other threads:[~2012-02-20 22:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-21 19:09 [PATCH 0/4][RFC] jump label: introduce default true branch Jason Baron
2011-12-21 19:09 ` [PATCH 1/4] jump label: Introduce default true branch + API update Jason Baron
2011-12-21 19:09 ` [PATCH 2/4] perf: Make use of updated jump label API Jason Baron
2011-12-21 19:09 ` [PATCH 3/4] tracepoints: update to use new " Jason Baron
2011-12-21 19:09 ` [PATCH 4/4] sched: Make use of " Jason Baron
2011-12-21 19:49 ` [PATCH 0/4][RFC] jump label: introduce default true branch Peter Zijlstra
2012-02-20 22:47 ` H. Peter Anvin
2012-02-20 22:51   ` Peter Zijlstra [this message]
2012-02-21 14:35     ` Jason Baron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329778301.2293.379.camel@twins \
    --to=a.p.zijlstra@chello.nl \
    --cc=davem@davemloft.net \
    --cc=ddaney.cavm@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jbaron@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@elte.hu \
    --cc=pjt@google.com \
    --cc=rostedt@goodmis.org \
    --cc=rth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.