From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH 08 of 10] libxl: Implement
 libxl_sched_credit_param_[gs]et
Date: Tue, 21 Feb 2012 17:56:16 +0000
Message-ID: <1329846976.2196.114.camel@elijah>
References: <patchbomb.1329831246@kodo2>
	<d70161aab13edea6f2f4.1329831254@kodo2>
	<20291.55722.928406.510062@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20291.55722.928406.510062@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2012-02-21 at 17:51 +0000, Ian Jackson wrote:
> George Dunlap writes ("[Xen-devel] [PATCH 08 of 10] libxl: Implement libxl_sched_credit_param_[gs]et"):
> > Implement functions to set credit scheduler global parameters.
> 
> Again, just some niggles:
> 
> > +int libxl_sched_credit_param_get(libxl_ctx *ctx, uint32_t poolid, libxl_sched_credit_param *scinfo)
> 
> Long line here and in _set.
> 
> Shouldn't this be "params" rather than "param" since it sets several
> parameters ?

Hmm, I suppose so.  I think I accidentally said "param" because I
originally wrote the patch series, the structure actually only contained
one parameter.  Then I thought I might as well do both at the same time,
but didn't have to re-write this patch. :-)

 -George