From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH 10 of 10] xl: Implement sched-credit schedule parameter command-line interface Date: Tue, 21 Feb 2012 18:11:53 +0000 Message-ID: <1329847913.2196.123.camel@elijah> References: <4f3e3d7016735b6c7a28.1329831256@kodo2> <20291.56025.490397.260688@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20291.56025.490397.260688@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: George Dunlap , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On Tue, 2012-02-21 at 17:56 +0000, Ian Jackson wrote: > George Dunlap writes ("[Xen-devel] [PATCH 10 of 10] xl: Implement sched-credit schedule parameter command-line interface"): > > Add features to the sched-credit interface to allow querying and > > displaying scheduler parameters. New interface works as follows: > > > > : List all domain params and sched params from all pools > > -d [domid] : List domain params for domain > > -d [domid] [params] : Set domain params for domain > > -p [pool] : list all domains and sched params for pool > > -s : List sched params for poolid 0 > > -s [params] : Set sched params for poolid 0 > > -p [pool] -s : List sched params for pool > > -p [pool] -s [params] : Set sched params for pool > > -p [pool] -d... : Illegal > > This information should be in the xl manpage, rather than in the > commit message and a code comment. Of course. And, is there some other documentation that this should be put into as well? > > > +static int sched_credit_param_set( > > + int poolid, libxl_sched_credit_param *scinfo) > > +{ > > Formatting. It should be > > static int sched_credit_param_set(int poolid, libxl_sched_credit_param *scinfo) > > (79 columns) or > > static int sched_credit_param_set(int poolid, > libxl_sched_credit_param *scinfo) > > (67 columns). > > This should be changed throughout I'm afraid. Ack. > > > + } else { /* Set scheduling parameters*/ > > + rc = sched_credit_param_get(poolid, &scparam); > > What happens if the pool isn't using the credit scheduler ? Ah, good point. I suppose it should just print the pool name. What happens to output of domains when you use xl sched-credit and there is a pool that's not using the credit scheduler? It looks like it will stop at that point and quit processing. It seems like having it print the domain ID and "[not sched-credit]" or something like that would be better. What would be *even* better is to unify these all somehow, so that xl would automatically detect the appropriate scheduler for the pool and behave accordingly. But that's a patch series for another time, I think. -George