From: "Khem Raj" <raj.khem@gmail.com>
To: Sinan Kaya <okaya@kernel.org>, openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [meta-oe][PATCH] c-ares: remove custom patches
Date: Mon, 23 Aug 2021 09:45:01 -0700 [thread overview]
Message-ID: <132bbd2c-d3f7-8fe7-7547-b0e72cbfcc98@gmail.com> (raw)
In-Reply-To: <de13dbbb-9131-8ee4-dd05-4b3ca6bcdf3c@kernel.org>
On 8/23/21 9:31 AM, Sinan Kaya wrote:
> On 8/23/2021 7:07 PM, Khem Raj wrote:
>>> delete mode 100644
>>> meta-oe/recipes-support/c-ares/c-ares/cmake-install-libcares.pc.patch
>>>
>>
>> Its always good to drop some patches we are carrying, however, if you
>> could describe the reason why they should be removed, would give a good
>> idea if they are good to remove or not.
>
> Current patch is breaking the library dependencies added by cmake
> especially when you are static linking (context is mingw for me).
>
> Applications need the ws2_32 library to be linked and with the existing
> patch this is not getting passed to the users.
>
> Using the stock CMakeLists.txt, stuff mostly works (minus some patches
> that I'm upstreaming now).
>
perhaps https://github.com/c-ares/c-ares/issues/373 was being addressed
by 0001-fix-configure-error-mv-libcares.pc.cmakein-to-libcar.patch and
cmake-install-libcares.pc.patch was to generate and install libcares.pc
when using cmake buildsystem. Can you take a closer look if these issues
are handled properly in upstream code itself. Secondly add this
information to commit message as well
prev parent reply other threads:[~2021-08-23 16:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 15:13 [meta-oe][PATCH] c-ares: remove custom patches Sinan Kaya
2021-08-23 16:07 ` [oe] " Khem Raj
2021-08-23 16:31 ` Sinan Kaya
2021-08-23 16:45 ` Khem Raj [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=132bbd2c-d3f7-8fe7-7547-b0e72cbfcc98@gmail.com \
--to=raj.khem@gmail.com \
--cc=okaya@kernel.org \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.