From: Colin Walters <walters@verbum.org>
To: Pekka Enberg <penberg@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: Re: [PATCH] perf report: Add a simple GTK2-based 'perf report' browser
Date: Thu, 23 Feb 2012 14:36:41 -0500 [thread overview]
Message-ID: <1330025802.17301.1.camel@lenny> (raw)
In-Reply-To: <1330013922-3332-1-git-send-email-penberg@kernel.org>
On Thu, 2012-02-23 at 18:18 +0200, Pekka Enberg wrote:
> This patch adds a simple GTK2-based browser to 'perf report' that's based on
> the TTY-based browser in builtin-report.c.
>
> Please not that you need to use
>
> make WERROR=0
You could -Wnoerror=strict-prototypes...
>
> to build perf on Fedora 15 (and possibly other distributions) because GTK
> headers do not compile cleanly:
>
> CC util/gtk/browser.o
> In file included from /usr/include/gtk-2.0/gtk/gtk.h:234:0,
> from util/gtk/browser.c:7:
> /usr/include/gtk-2.0/gtk/gtkitemfactory.h:47:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
Unfortunately it was a historical mistake, but it's part of the public
API:
https://bugzilla.gnome.org/show_bug.cgi?id=508760
next prev parent reply other threads:[~2012-02-23 19:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 16:18 [PATCH] perf report: Add a simple GTK2-based 'perf report' browser Pekka Enberg
2012-02-23 16:28 ` Arnaldo Carvalho de Melo
2012-02-23 16:32 ` Pekka Enberg
2012-02-23 16:39 ` Arnaldo Carvalho de Melo
2012-02-23 16:45 ` Pekka Enberg
2012-02-23 16:47 ` Arnaldo Carvalho de Melo
2012-02-23 16:53 ` Arnaldo Carvalho de Melo
2012-02-23 17:10 ` Pekka Enberg
2012-02-23 17:37 ` Arnaldo Carvalho de Melo
2012-02-23 17:52 ` Pekka Enberg
2012-02-24 0:58 ` Namhyung Kim
2012-02-24 6:36 ` Pekka Enberg
2012-03-19 20:08 ` [tip:perf/core] " tip-bot for Pekka Enberg
2012-02-23 19:36 ` Colin Walters [this message]
2012-02-23 20:18 ` [PATCH] " Pekka Enberg
2012-02-23 20:33 ` Colin Walters
2012-02-23 21:27 ` Pekka Enberg
2012-02-24 9:48 ` Ingo Molnar
2012-02-24 10:05 ` Pekka Enberg
2012-03-16 19:48 ` Arnaldo Carvalho de Melo
2012-03-19 18:12 ` Arnaldo Carvalho de Melo
2012-03-27 10:26 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330025802.17301.1.camel@lenny \
--to=walters@verbum.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.