Re: [PATCH 9/9] runqueue: fire sceneQueueTaskStarted event when a setscene queue starts

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2012-02-23 at 21:47 +0800, Dongxiao Xu wrote:
> The current code prints a log when a setscene task starts, therefore
> the progressbar in hob will not receive it. Use a sceneQueueTaskStarted
> event instead.
> 
> Signed-off-by: Shane Wang <shane.wang@intel.com>
> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
> ---
>  lib/bb/runqueue.py |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/lib/bb/runqueue.py b/lib/bb/runqueue.py
> index d1d9ad9..ef28415 100644
> --- a/lib/bb/runqueue.py
> +++ b/lib/bb/runqueue.py
> @@ -1653,6 +1653,9 @@ class RunQueueExecuteScenequeue(RunQueueExecute):
>                  self.task_skip(task)
>                  return True
>  
> +            startevent = sceneQueueTaskStarted(task, self.stats, self.rq)
> +            bb.event.fire(startevent, self.cfgData)
> +
>              pid, pipein, pipeout = self.fork_off_task(fn, realtask, taskname)
>  
>              self.build_pids[pid] = task
> @@ -1720,6 +1723,13 @@ class runQueueTaskStarted(runQueueEvent):
>          runQueueEvent.__init__(self, task, stats, rq)
>          self.noexec = noexec
>  
> +class sceneQueueTaskStarted(runQueueTaskStarted):
> +    """
> +    Event notifing a setscene task was started
> +    """
> +    def __init__(self, task, stats, rq, noexec=False):
> +        runQueueTaskStarted.__init__(self, task, stats, rq, noexec)
> +

This one has me a little worried since it inherits runQueueTaskStarted
and a UI might confuse this with real runQueueTaskStarted() events. Is
there something else we can inherit here?

Cheers,

Richard