Re: [PATCH 0/1][PULL] Hob2: A new implementation for Human Oriented Builder

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2012-02-23 at 21:48 +0800, Dongxiao Xu wrote:
> Hi Richard,
> 
> This pull request is a new implementation for Human Oriented Builder, please help to review and pull.
> 
> Changes from previous pull requests:
>  - Re-implemented a lot of code according to Belen's new GUI design.
> 
> Note that this pull request depends on the following pull requests:
>  - hob2-bitbake-changes
>  - hob2-oecore-changes
> 
> Thanks,
> Dongxiao
> 
> 
> The following changes since commit cec8b6e6c33582be660dd35c6050efc3f28e6baa:
> 
>   runqueue: fire sceneQueueTaskStarted event when a setscene queue starts (2012-02-23 21:04:49 +0800)
> 
> are available in the git repository at:
>   git://git.pokylinux.org/poky-contrib dxu4/hob2
>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob2
> 
> Dongxiao Xu (1):
>   Hob: A new implemetation for Human Oriented Builder

I just merged this branch however there are some things I need to make
clear, particularly why I've done it and why this should never happen
again.

Having everything as one huge monster patch effectively means its
impossible to review. I've taken it since it would probably take weeks
to split into changesets and I'm not sure that would be productive work.
At least if its in master, people can test it out and send
patches/incremental improvements from now on so I have taken it on this
basis. I want to make it clear this is a one time exception and isn't
going to be acceptable in future.

Secondly, I merged the patch but didn't realise it was corrupt, some
files had the prefix "bitbake/" and some did not. I've corrected this
but it caused me quite a bit of confusion.

Joshua's reply in this thread also has some valid questions I'd like to
see answered. 

I'd also like to stress the Human Oriented Builder name needs to die
(sorry Dave), I removed it from the commit message.

All the above isn't to say I don't love the progress we're making with
the UI btw, we just also need to keep an eye on the housekeeping stuff
too.

Cheers,

Richard