All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonas Bonn <jonas@southpole.se>
To: Richard Weinberger <richard@nod.at>
Cc: arnd@arndb.de, linux@openrisc.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] OpenRISC: IRQ: Include module.h
Date: Wed, 29 Feb 2012 08:49:09 +0100	[thread overview]
Message-ID: <1330501749.2964.4.camel@crucifix> (raw)
In-Reply-To: <1330476393-14264-2-git-send-email-richard@nod.at>


Thanks.  There is already a patch in linux-next for this.

However, the patch in linux-next pulls in export.h instead of module.h.
I think export.h is the correct header file to be using here, but let me
know if you see it differently.

Thanks for helping out with build-testing the OpenRISC arch... much
appreciated.

/Jonas

On Wed, 2012-02-29 at 01:46 +0100, Richard Weinberger wrote:
> Fixes:
>   CC      arch/openrisc/kernel/irq.o
> arch/openrisc/kernel/irq.c:35:1: warning: data definition has no type or storage class
> arch/openrisc/kernel/irq.c:35:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL’
> arch/openrisc/kernel/irq.c:35:1: warning: parameter names (without types) in function declaration
> arch/openrisc/kernel/irq.c:42:1: warning: data definition has no type or storage class
> arch/openrisc/kernel/irq.c:42:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL’
> arch/openrisc/kernel/irq.c:42:1: warning: parameter names (without types) in function declaration
> arch/openrisc/kernel/irq.c:173:1: warning: data definition has no type or storage class
> arch/openrisc/kernel/irq.c:173:1: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL_GPL’
> arch/openrisc/kernel/irq.c:173:1: warning: parameter names (without types) in function declaration
> 
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
>  arch/openrisc/kernel/irq.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/openrisc/kernel/irq.c b/arch/openrisc/kernel/irq.c
> index 59b3023..f917925 100644
> --- a/arch/openrisc/kernel/irq.c
> +++ b/arch/openrisc/kernel/irq.c
> @@ -14,6 +14,7 @@
>   *      2 of the License, or (at your option) any later version.
>   */
>  
> +#include <linux/module.h>
>  #include <linux/ptrace.h>
>  #include <linux/errno.h>
>  #include <linux/interrupt.h>



  reply	other threads:[~2012-02-29  7:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-29  0:46 [PATCH 1/2] OpenRISC: Fix audit_syscall_exit() usage Richard Weinberger
2012-02-29  0:46 ` [PATCH 2/2] OpenRISC: IRQ: Include module.h Richard Weinberger
2012-02-29  7:49   ` Jonas Bonn [this message]
2012-02-29  8:39     ` Richard Weinberger
2012-02-29  8:56       ` Jonas Bonn
2012-02-29  7:46 ` [PATCH 1/2] OpenRISC: Fix audit_syscall_exit() usage Jonas Bonn
2012-02-29  8:34   ` Richard Weinberger
2012-02-29  8:48     ` Jonas Bonn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330501749.2964.4.camel@crucifix \
    --to=jonas@southpole.se \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@openrisc.net \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.