All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: "Lesław Kopeć" <leslaw.kopec@nasza-klasa.pl>
Cc: Aman Gupta <aman@tmm1.net>,
	linux-kernel@vger.kernel.org,
	Chase Douglas <chase.douglas@canonical.com>,
	Damien Wyart <damien.wyart@free.fr>,
	Kyle McMartin <kyle@redhat.com>,
	Venkatesh Pallipadi <venki@google.com>,
	Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: Inconsistent load average on tickless kernels
Date: Wed, 29 Feb 2012 18:03:18 +0100	[thread overview]
Message-ID: <1330534998.11248.158.camel@twins> (raw)
In-Reply-To: <1330532667.11248.153.camel@twins>

On Wed, 2012-02-29 at 17:24 +0100, Peter Zijlstra wrote:
> 
> The only thing I could find is that on nohz we can confuse the per-rq
> sample period, does the below make a difference? 

Uhm, something like so that is.. 

---
 kernel/sched/core.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index d7c4322..44f61df 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -2380,7 +2380,8 @@ static void calc_load_account_active(struct rq *this_rq)
 	if (delta)
 		atomic_long_add(delta, &calc_load_tasks);
 
-	this_rq->calc_load_update += LOAD_FREQ;
+	while (!time_before(jiffies, this_rq->calc_load_update))
+		this_rq->calc_load_update += LOAD_FREQ;
 }
 
 /*


  reply	other threads:[~2012-02-29 17:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-06  6:51 Inconsistent load average on tickless kernels Aman Gupta
2012-02-23 15:46 ` Lesław Kopeć
2012-02-29 12:06   ` Peter Zijlstra
2012-02-29 16:24     ` Peter Zijlstra
2012-02-29 17:03       ` Peter Zijlstra [this message]
2012-03-05 19:57         ` Lesław Kopeć
2012-03-05 22:45           ` Aman Gupta
2012-03-05 23:25             ` Peter Zijlstra
2012-03-05 23:32               ` Peter Zijlstra
2012-03-05 23:33                 ` Peter Zijlstra
2012-04-17 12:52                   ` Lesław Kopeć
2012-04-17 15:30                     ` Jonathan Nieder
2012-04-23 16:20                       ` Lesław Kopeć
2012-04-23 17:57                         ` Jonathan Nieder
2012-04-23 20:21                           ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330534998.11248.158.camel@twins \
    --to=peterz@infradead.org \
    --cc=aman@tmm1.net \
    --cc=chase.douglas@canonical.com \
    --cc=damien.wyart@free.fr \
    --cc=jrnieder@gmail.com \
    --cc=kyle@redhat.com \
    --cc=leslaw.kopec@nasza-klasa.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=venki@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.