From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gusakov Andrey Subject: [PATCH v3] ARM: S3C24XX DMA resume regression fix Date: Thu, 1 Mar 2012 17:53:51 +0400 Message-ID: <1330610031-2237-1-git-send-email-dron0gus@gmail.com> References: <077201ccf767c6d1ec05475c40$%kim@samsung.com> Return-path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:59289 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759326Ab2CANzI (ORCPT ); Thu, 1 Mar 2012 08:55:08 -0500 Received: by bkcik5 with SMTP id ik5so515479bkc.19 for ; Thu, 01 Mar 2012 05:55:06 -0800 (PST) In-Reply-To: <077201ccf767c6d1ec05475c40$%kim@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Ben Dooks , Kukjin Kim Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, heiko@sntech.de, Gusakov Andrey s3c2410_dma_suspend suspends channels from 0 to dma_channels. s3c2410_dma_resume resumes channels in reverse order. So pointer should be decremented instead of being incremented. Signed-off-by: Gusakov Andrey Reviewed-by: Heiko Stuebner --- arch/arm/plat-s3c24xx/dma.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c index 57abec9..16510d5 100644 --- a/arch/arm/plat-s3c24xx/dma.c +++ b/arch/arm/plat-s3c24xx/dma.c @@ -1249,7 +1249,7 @@ static void s3c2410_dma_resume(void) struct s3c2410_dma_chan *cp = s3c2410_chans + dma_channels - 1; int channel; - for (channel = dma_channels - 1; channel >= 0; cp++, channel--) + for (channel = dma_channels - 1; channel >= 0; cp--, channel--) s3c2410_dma_resume_chan(cp); } -- 1.7.0.4 From mboxrd@z Thu Jan 1 00:00:00 1970 From: dron0gus@gmail.com (Gusakov Andrey) Date: Thu, 1 Mar 2012 17:53:51 +0400 Subject: [PATCH v3] ARM: S3C24XX DMA resume regression fix In-Reply-To: <077201ccf767c6d1ec05475c40$%kim@samsung.com> References: <077201ccf767c6d1ec05475c40$%kim@samsung.com> Message-ID: <1330610031-2237-1-git-send-email-dron0gus@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org s3c2410_dma_suspend suspends channels from 0 to dma_channels. s3c2410_dma_resume resumes channels in reverse order. So pointer should be decremented instead of being incremented. Signed-off-by: Gusakov Andrey Reviewed-by: Heiko Stuebner --- arch/arm/plat-s3c24xx/dma.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c index 57abec9..16510d5 100644 --- a/arch/arm/plat-s3c24xx/dma.c +++ b/arch/arm/plat-s3c24xx/dma.c @@ -1249,7 +1249,7 @@ static void s3c2410_dma_resume(void) struct s3c2410_dma_chan *cp = s3c2410_chans + dma_channels - 1; int channel; - for (channel = dma_channels - 1; channel >= 0; cp++, channel--) + for (channel = dma_channels - 1; channel >= 0; cp--, channel--) s3c2410_dma_resume_chan(cp); } -- 1.7.0.4